Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rpm platforms without yum #717

Merged
merged 1 commit into from
May 15, 2024
Merged

Support rpm platforms without yum #717

merged 1 commit into from
May 15, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented May 13, 2024

observed the latest rockylinux 9 containers do not have a yum symlink to dnf anymore.

Related:

@h0tw1r3
support rpm platforms with dnf only
0a246a5 
observed the latest rockylinux 9 containers do not have a yum symlink
to dnf anymore.
@h0tw1r3 h0tw1r3 added bug Something isn't working enhancement New feature or request labels May 13, 2024
@h0tw1r3 h0tw1r3 requested review from bastelfreak and a team as code owners May 13, 2024 14:11
@h0tw1r3 h0tw1r3 mentioned this pull request May 13, 2024
Merged
2 tasks
donoghuc
donoghuc reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the default remain yum in the case both are present?

@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 14, 2024 •
edited
Loading

Should the default remain yum in the case both are present?

No, technically yum has been deprecated since EL8. Anytime it's present it should be preferred.

donoghuc
donoghuc approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like PR tests are unrelated. This seems like a good change. thanks

gavindidrichsen
gavindidrichsen approved these changes May 15, 2024
View reviewed changes
Copy link

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@donoghuc donoghuc merged commit a23343b into puppetlabs:main May 15, 2024
9 of 17 checks passed
@h0tw1r3 h0tw1r3 deleted the dnf-support branch May 17, 2024 17:54
shubhamshinde360 added a commit to shubhamshinde360/install-puppet that referenced this pull request Jun 21, 2024
@shubhamshinde360
(PA-6047) Add support for Ubuntu 24.04
8cefb6b 
Changes from amazon renaming puppetlabs/puppetlabs-puppet_agent#721
and dnf support addition puppetlabs/puppetlabs-puppet_agent#717 have also aggregated here
@shubhamshinde360 shubhamshinde360 mentioned this pull request Jun 21, 2024
Merged
shubhamshinde360 added a commit to shubhamshinde360/install-puppet that referenced this pull request Jun 21, 2024
@shubhamshinde360
(PA-6047) Add support for Ubuntu 24.04
3bdd09a 
Changes for dnf support addition puppetlabs/puppetlabs-puppet_agent#717 have also aggregated here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanbreen28 jordanbreen28 jordanbreen28 approved these changes

@gavindidrichsen gavindidrichsen gavindidrichsen approved these changes

@donoghuc donoghuc donoghuc approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h0tw1r3 @bastelfreak @donoghuc @gavindidrichsen @jordanbreen28