Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Prep for 1.1.0 #87

Merged
merged 1 commit into from
Mar 1, 2016
Merged

Conversation

HelenCampbell
Copy link
Contributor

This is a changelog and metadata update for the new 1.1.0 release of this module.

@HelenCampbell
Copy link
Contributor Author

Hey @highb and @jpartlow (I wasn't sure who to ping on this, but you two seem to be the most regular contributors in the past few months). I'm doing a new release for this module and this is the release prep for it. Would you be able to review and merge for me please? Thanks!

@DavidS
Copy link

DavidS commented Feb 26, 2016

👍

@jpartlow
Copy link
Contributor

Hi @HelenCampbell @DavidS

Unfortunately the module work isn't quite completed. There are three areas outstanding (https://tickets.puppetlabs.com/browse/PE-11589 is the general epic)

For that later one, should we revert the solaris11 work prior to release, or simple update the documentation to make it clear that solaris11 upgrades have known issues. Probably the later?

Josh

@HelenCampbell
Copy link
Contributor Author

Hey @jpartlow , Following the email chain about this, I've updated the changelog and readme to include a list of known issues, would you take a look for me and ensure I'm saying the correct thing?

@@ -112,6 +112,11 @@ In addition, there are several known issues with Windows:
* On Windows Server 2003, only x86 is supported, and the `arch` parameter is ignored. If you try to force an upgrade to x64, Puppet installs the x86 version with no error message.
* On Windows Server 2003 with Puppet Enterprise, the default download location is unreachable. You can work around this issue by specifying an alternate download URL in the `source` parameter.

Specifically in the 1.1.0 Release:
* For Windows, trigger an agent run to get Puppet to create the nessesary directory structures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nessesary => necessary

@bmjen
Copy link
Contributor

bmjen commented Mar 1, 2016

Just some docs cleanup needed. So that we don't churn out a docs PR for signoffs.

All occurrences of windows needs to be Windows.

@HelenCampbell
Copy link
Contributor Author

Good catch @bmjen. Fixed.

@bmjen
Copy link
Contributor

bmjen commented Mar 1, 2016

/cc @jpartlow can you review the CHANGELOG to make sure we got everything?


### Known issues
While this release adds considerable features and bug fixes the following areas are known issues and require more work:
- For Windows, trigger an agent run to get Puppet to create the nessesary directory structures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below I would add 'after upgrade': 'trigger an agent run after upgrade'

Could also caveat that to puppet resource calls will fail until the first puppet agent run. (You really don't need a manual puppet agent run unless you have to call puppet resource prior to the first daemonized agent run...if it's worth splitting the hair).

@highb
Copy link
Contributor

highb commented Mar 1, 2016

👍 from me.

bmjen added a commit that referenced this pull request Mar 1, 2016
@bmjen bmjen merged commit 0a30699 into puppetlabs:master Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants