-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Prep for 1.1.0 #87
Conversation
👍 |
Unfortunately the module work isn't quite completed. There are three areas outstanding (https://tickets.puppetlabs.com/browse/PE-11589 is the general epic)
For that later one, should we revert the solaris11 work prior to release, or simple update the documentation to make it clear that solaris11 upgrades have known issues. Probably the later? Josh |
d285826
to
b53f7e3
Compare
Hey @jpartlow , Following the email chain about this, I've updated the changelog and readme to include a list of known issues, would you take a look for me and ensure I'm saying the correct thing? |
@@ -112,6 +112,11 @@ In addition, there are several known issues with Windows: | |||
* On Windows Server 2003, only x86 is supported, and the `arch` parameter is ignored. If you try to force an upgrade to x64, Puppet installs the x86 version with no error message. | |||
* On Windows Server 2003 with Puppet Enterprise, the default download location is unreachable. You can work around this issue by specifying an alternate download URL in the `source` parameter. | |||
|
|||
Specifically in the 1.1.0 Release: | |||
* For Windows, trigger an agent run to get Puppet to create the nessesary directory structures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nessesary
=> necessary
Just some docs cleanup needed. So that we don't churn out a docs PR for signoffs. All occurrences of |
b53f7e3
to
903e655
Compare
Good catch @bmjen. Fixed. |
/cc @jpartlow can you review the CHANGELOG to make sure we got everything? |
|
||
### Known issues | ||
While this release adds considerable features and bug fixes the following areas are known issues and require more work: | ||
- For Windows, trigger an agent run to get Puppet to create the nessesary directory structures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and below I would add 'after upgrade': 'trigger an agent run after upgrade'
Could also caveat that to puppet resource
calls will fail until the first puppet agent run. (You really don't need a manual puppet agent run unless you have to call puppet resource prior to the first daemonized agent run...if it's worth splitting the hair).
903e655
to
5546ca4
Compare
👍 from me. |
This is a changelog and metadata update for the new 1.1.0 release of this module.