Add support for using both match and after #317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were running "match" handler ignoring "after" param. This patch enables us to use both "match" and "after" resource parameters: if "match" is found, then we simply replace the line, if it's not found and we have "after", then we add lines after the specified pattern. If "match" and "after" not found, then we just append the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for "file_line" provider.
Previously we were running "match" handler ignoring "after" param.
This patch enables us to use both "match" and "after" resource
parameters: if "match" is found, then we simply replace the line,
if it's not found and we have "after", then we add line after the
specified pattern. If "match" and "after" not found, then we just
append the line.