(PDB-5645) Call handler with response when :include-response set #251
Conversation
|
|
|
I added the "don't merge" since this will support a forthcoming PDB pr, and thought I'd like to get that one settled too before we proceed, though I don't currently anticipate any further changes to this side. |
rbrw
force-pushed
the
pdb-5645-call-handler-with-response
branch
4 times, most recently
from
060d266
to
0a38c5f
Compare
|
@rbrw Note that we are working on the jetty 10 version of this service currently (we have everything but the web socket implementation working) with the intent of putting it into all the main branches soon. Assuming since this is a new feature it is only landing on the main branches, so you might want to delay until jetty 10 is done. |
|
See https://github.com/puppetlabs/trapperkeeper-webserver-jetty10 for reference. |
rbrw
force-pushed
the
pdb-5645-call-handler-with-response
branch
from
0a38c5f
to
51849ae
Compare
|
OK, thanks. Appreciate the notice. I think we'd like to merge this if we can sometime in the next two weeks (though after the releases), and yep, it's currently only intended for pdb 8. Also had to rework the approach a bit (now done). |
rbrw
force-pushed
the
pdb-5645-call-handler-with-response
branch
from
51849ae
to
3b9d020
Compare
rbrw
force-pushed
the
pdb-5645-call-handler-with-response
branch
from
3b9d020
to
95aca0f
Compare
CHANGELOG.md
Outdated
| @@ -1,3 +1,11 @@ | |||
| ## pending | |||
There was a problem hiding this comment.
If we are going to make an immediate release of this feature, I'd say we put the version here to save ourselves a PR.
| "Currently only provides support for aliased keyword access for | ||
| clojure versions without :as-alias (before 1.11)." | ||
| (:require | ||
| [clojure.spec.alpha :as s]) |
There was a problem hiding this comment.
Why spec here? It looks like the rest of the project is still on prismatic
If :include-response is true in an add-ring-handler call, then include the pending request Response instance in the request map as :puppetlabs.trapperkeeper.services.webserver.jetty9/response so that the handler can interrogate/manipulate the response directly if desired. PuppetDB intends to use this to detect client disconnects via the SocketChannel (via the Response getHttpChannel) in order to halt a potentially expensive query sooner.
rbrw
force-pushed
the
pdb-5645-call-handler-with-response
branch
from
95aca0f
to
571d6e6
Compare
If :include-response is true in an add-ring-handler call, then call the handler with the pending request Response as a second argument so that the handler can interrogate/manipulate the response directly if desired. PuppetDB intends to use this to detect client disconnects via the SocketChannel (via the Response getHttpChannel) in order to halt a potentially expensive query sooner.