Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version numbers of the snapshots #286

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

akirak
Copy link
Collaborator

@akirak akirak commented Jul 2, 2024

Emacs master has been bumped up. emacs-30 branch has been cut off, and do you update the emacs-release-snapshot input?

@purcell purcell closed this Jul 2, 2024
@purcell purcell reopened this Jul 2, 2024
@purcell purcell merged commit ebc7448 into purcell:master Jul 2, 2024
54 checks passed
@purcell
Copy link
Owner

purcell commented Jul 2, 2024

Thank you!

@basil-conto
Copy link

emacs-30 branch has been cut off

Does that mean emacs-release-snapshot should be 30.0.60 instead of 29.4.50 (with the corresponding url change in the preceding inputs)?

@purcell
Copy link
Owner

purcell commented Jul 30, 2024

Hmm, not sure. Maybe not until Emacs 30 has actually been released? Unsure what's best tbh.

@akirak
Copy link
Collaborator Author

akirak commented Jul 30, 2024

#134 was the start.

I might even suggest as an alternative something like emacs-release-snapshot, which would aim to always build the head of the highest-numbered release branch

According to this definition, it should point to emacs-30 branch, which can be done by updating the corresponding flake input. Sorry for not being clear.

@akirak akirak deleted the update-versin-numbers branch July 30, 2024 11:08
@basil-conto
Copy link

basil-conto commented Jul 30, 2024

#134 was the start.

I might even suggest as an alternative something like emacs-release-snapshot, which would aim to always build the head of the highest-numbered release branch

According to this definition, it should point to emacs-30 branch

Makes sense to me: at any given time there are two active branches in emacs.git which neatly map to emacs-snapshot and emacs-release-snapshot. Older branches like emacs-29 no longer receive updates except for emergency bugfixes, but those are meant to be rare and are soon released separately, as was the case for 29.3 and 29.4.

IOW, nix-emacs-ci currently skips from 29 to 31, and doesn't reflect the active development happening in 30. (I'm not implying there is any obligation to of course; just noting an observation.)

@akirak
Copy link
Collaborator Author

akirak commented Jul 30, 2024

I have opened #291 to follow the definition.

@purcell
Copy link
Owner

purcell commented Jul 30, 2024

Yes, makes sense, thanks! (I merged that PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants