Update for PureScript 0.14 #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoneyman
commented
Jan 23, 2021
server/Main.hs
Outdated
| results = nubBy ((==) `on` fst) $ do | ||
| elab <- elabs | ||
| let strictMatches = search (replaceTypeVariablesAndDesugar (\nm s -> P.Skolem P.NullSourceAnn nm s (P.SkolemScope 0)) elab) | ||
| let strictMatches = search (replaceTypeVariablesAndDesugar (\nm s -> P.Skolem P.NullSourceAnn nm Nothing s (P.SkolemScope 0)) elab) |
Member
Author
There was a problem hiding this comment.
Skolems are now tagged with their kinds as per the PolyKinds PR, so there's an additional argument:
If setting this to Nothing is the wrong approach, I'd appreciate a note on where I might find this information.
thomashoneyman
requested review from
hdgarrood and
natefaubion
and removed request for
hdgarrood
hdgarrood
reviewed
Jan 24, 2021
….Make.rebuildModule in compile.
hdgarrood
approved these changes
Jan 25, 2021
This was referenced May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR updates Try PureScript for compatibility with PureScript 0.14.x. In this case I'm using the latest commit for 0.14.0-rc5 in Stack via GitHub. The changes are straightforward, but I'm now throwing away warnings (which weren't previously present) so that's worth a look to see if we can make better use of them.
I haven't been able to thoroughly test this yet, but if I can load up the prepare-0.14 package set locally for testing purposes then I will report those results back.
Unlike Pursuit, we won't want to deploy this until after 0.14 is out and we can rely on a new package set. But I still wanted to get this ready for release so we're ready to deploy as soon as that package set is together.
Thanks also to @colinwahl for working on this with me.