Update development instructions #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoneyman
requested review from
JordanMartinez and
hdgarrood
and removed request for
JordanMartinez
hdgarrood
reviewed
May 28, 2021
hdgarrood
approved these changes
May 28, 2021
Contributor
|
I did the following:
Looking at the developer tools, the 500 error had this message: |
JordanMartinez
approved these changes
May 29, 2021
Contributor
JordanMartinez
left a comment
JordanMartinez
left a comment
There was a problem hiding this comment.
I think the fact that Thomas got it to work shows that there might be a problem with my environment. I'm not sure what that may be. Should we merge this anyway since it worked for at least one person?
Member
Author
|
@JordanMartinez I’m on MacOS using zsh; perhaps there’s a difference between operating systems or shells? |
Member
Author
|
I’m going to merge as this at least gets the instructions right in general, but ideally we get it working across systems. |
Contributor
Sounds good to me! Thanks for all your work on getting this updated to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202, #196, #183. Confirmed that on a fresh clone of Try PureScript, following these instructions exactly, I can run the client against a local server or the production Try PureScript server with no additional tools or steps. cc: @milesfrain.