From 9cb9d5156d65bb234d66b21a7ad9591cb45e499c Mon Sep 17 00:00:00 2001 From: Yakov Karpov Date: Thu, 21 Apr 2022 14:24:28 +0300 Subject: [PATCH 1/2] Fix comments --- Makefile | 2 +- makefiles/platform/mac.mk | 2 +- makefiles/test.mk | 12 ++++++------ 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index a351280..1d57ede 100644 --- a/Makefile +++ b/Makefile @@ -2,7 +2,7 @@ flutter = (fvm flutter || flutter) -# Описание скрипта по `make` или `make help` +# Script description and usage through `make` or `make help` commands help: @echo "Make something good" @echo " or something worse" diff --git a/makefiles/platform/mac.mk b/makefiles/platform/mac.mk index b442bf9..60dba52 100644 --- a/makefiles/platform/mac.mk +++ b/makefiles/platform/mac.mk @@ -19,7 +19,7 @@ ios-deep-clean: @make pub-get @make install-pods -# Запустить кодогенерацию в фоне +# Runes code generation in background codegen-bg: @nohup time /bin/bash -c ' \ flutter pub get \ diff --git a/makefiles/test.mk b/makefiles/test.mk index b433474..a2316ab 100644 --- a/makefiles/test.mk +++ b/makefiles/test.mk @@ -1,10 +1,10 @@ .PHONY: test coverage -# Запустить тесты +# Run tests test: @time timeout 300 flutter test --concurrency=6 --dart-define=environment=testing --coverage test/ -# Запустить все тесты и собрать общее покрытие +# Run tests and generate coverage report coverage: test @ #mv coverage/lcov.info coverage/lcov.base.info @ #lcov -r coverage/lcov.base.info -o coverage/lcov.base.info "lib/**.freezed.dart" "lib/**.g.dart" @@ -14,7 +14,7 @@ coverage: test @lcov --summary coverage/lcov.info @genhtml -o coverage coverage/lcov.info -# Интеграционные тесты +# Run integration tests integration: @flutter test \ --flavor integration \ @@ -22,10 +22,10 @@ integration: --coverage \ integration_test/app_test.dart -# Запустить тесты на последней стейбл версии флатера с поддержкой веба +# Run tests on the latest stable version with web support # https://hub.docker.com/r/plugfox/flutter/tags?page=1&name=stable-web # -# Если необходимо добавить sqlite последней версии: +# Add the latest SQLite support: # ``` # echo "https://dl-cdn.alpinelinux.org/alpine/edge/main" > /etc/apk/repositories \ # echo "https://dl-cdn.alpinelinux.org/alpine/edge/community" >> /etc/apk/repositories \ @@ -33,7 +33,7 @@ integration: # apk update && apk --no-cache add sqlite sqlite-dev lcov # ``` # -# Сконфигурировать git: +# Configure git: # ``` # git config --global user.email "developer@domain.tld" \ # git config --global user.name "Flutter Developer" \ From c905d6e80e2ddc7225332e7e2d7a693d02f3a03a Mon Sep 17 00:00:00 2001 From: Yakov Karpov Date: Thu, 21 Apr 2022 14:26:04 +0300 Subject: [PATCH 2/2] Fix ParsingException message --- lib/src/core/error/parsing_exception.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/core/error/parsing_exception.dart b/lib/src/core/error/parsing_exception.dart index 3a8eda9..7b09f28 100644 --- a/lib/src/core/error/parsing_exception.dart +++ b/lib/src/core/error/parsing_exception.dart @@ -4,5 +4,5 @@ class ParsingException implements Exception { ParsingException(this.from); @override - String toString() => 'ParsingException ocurred when parsing from $from'; + String toString() => '$runtimeType ocurred when parsing from $from'; }