Compose Multiplatform support #35
Conversation
|
This looks great! 💯 Thanks for raising this PR. Let me review this. |
|
Hi, any updates on this PR? |
|
Working on reviewing the code and getting this merged asap. |
|
Thank you! |
pushpalroy
added
enhancement
|
Thank you so much for this PR! I really needed a timeline feature in my desktop app, and this is going to save me a lot of time. |
|
Amazing work |
|
Great job! Is there any ETA for when the PR is going to be merged? |
This PR should be merged by this month and a KMP library will be released. |
# Conflicts: # .idea/deploymentTargetSelector.xml # .idea/kotlinc.xml # gradle/libs.versions.toml # gradle/wrapper/gradle-wrapper.properties # sample/composeApp/src/commonMain/kotlin/Home.kt # sample/composeApp/src/commonMain/kotlin/timelines/BasicDashedTimeLine.kt
- fix merge conflict while updating PR to migrate library to kmm - bump kotlin to 2.0.20 - bump gradle to 8.10 - bump agp to 8.5.2
# Conflicts: # .gitignore # .idea/deploymentTargetSelector.xml # .idea/gradle.xml # .idea/kotlinc.xml
- downgrade kotlin to 2.0.20-RC2 - bump activityCompose to 1.9.1 - bump compose-plugin to 1.6.11 - bump dokka to 1.9.20 - bump androidxTest to 1.6.2
The library has been migrated to KMP now and released with version A huge shoutout to @pisoj for raising this PR and doing the heavy lifting! 👏🏻 👏🏻 This PR will be merged now and the ReadMe will be updated with migration details. |
|
Thank you so much for the porting and this PR! |
Introduces support for Compose Multiplatform projects. The library and the sample app are both migrated to support Android, iOS, Desktop (Windows, macOS, Linux) and the Web via
kotlin/wasm.As a result of this migration the project is now using Kotlin 2.0.0. I manually tested every platform except linux. All instrumented tests also pass. I ran
spotlessApplyand fixed all the issues, but for some reason it keeps making theAppfunction in/sample/composeApp/commonMain/kotlin/App.ktprivate and I have not found a way to fix that (it still does the same when I run./gradlew spotlessApply).I also do not know anything about publishing a library, so that part is untested, but generating documentation works.
To run on any desktop platform:
To run on web:
closes #30
closes #31
closes #34
Windows
Web
macOS
iOS
Android