From cd850a235d47a788ae02d062297636b7ac9a9400 Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Thu, 21 Mar 2024 01:18:52 +0100 Subject: [PATCH 01/14] Update plot_oedi_9068.py --- docs/examples/system-models/plot_oedi_9068.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index ffd66c2499..03d5a4afc7 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -231,7 +231,7 @@ ambiguous='NaT', nonexistent='NaT') # convert to standard time to match the NSRDB-based simulation -df_inverter_measred = df_inverter_measured.tz_convert('Etc/GMT+7') +df_inverter_measured = df_inverter_measured.tz_convert('Etc/GMT+7') # %% From ab3c2b38a5191342baadcf9f14c3105cfcf3081f Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Thu, 21 Mar 2024 01:23:02 +0100 Subject: [PATCH 02/14] Update v0.10.5.rst --- docs/sphinx/source/whatsnew/v0.10.5.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/sphinx/source/whatsnew/v0.10.5.rst b/docs/sphinx/source/whatsnew/v0.10.5.rst index e7097ea5b4..150c59eb40 100644 --- a/docs/sphinx/source/whatsnew/v0.10.5.rst +++ b/docs/sphinx/source/whatsnew/v0.10.5.rst @@ -23,6 +23,8 @@ Testing Documentation ~~~~~~~~~~~~~ +* Fix variable name typo at + ``docs\examples\system-models\plot_oedi_9068.py``, (:pull:`1996`) Requirements From 9d083079128862b78ffb659e148aa7d499d739c2 Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Tue, 2 Apr 2024 18:34:31 +0200 Subject: [PATCH 03/14] Add thumbnail (hopefully) --- docs/examples/system-models/plot_oedi_9068.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index 03d5a4afc7..aafff85c45 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -5,6 +5,8 @@ A basic model of a 4.7 MW single-axis tracking CdTe system located in Colorado, United States. """ +# sphinx_gallery_thumbnail_path = \ +# "../../_images/OEDI_9068_inverter1_comparison.png" # %% # This example model uses satellite-based solar resource data from the From ac255bbac871656ff4305dfa11b85588bf68d69e Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Tue, 2 Apr 2024 18:43:44 +0200 Subject: [PATCH 04/14] Multiline config vars not allowed? --- docs/examples/system-models/plot_oedi_9068.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index aafff85c45..ff73006dfd 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -5,8 +5,7 @@ A basic model of a 4.7 MW single-axis tracking CdTe system located in Colorado, United States. """ -# sphinx_gallery_thumbnail_path = \ -# "../../_images/OEDI_9068_inverter1_comparison.png" +# sphinx_gallery_thumbnail_path = "../../_images/OEDI_9068_inverter1_comparison.png" # %% # This example model uses satellite-based solar resource data from the From 651475d394d7a5246fb18e63916037fc934e0f0f Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Tue, 2 Apr 2024 18:54:49 +0200 Subject: [PATCH 05/14] who knows if this works --- docs/examples/system-models/plot_oedi_9068.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index ff73006dfd..09f51f4b9e 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -5,7 +5,6 @@ A basic model of a 4.7 MW single-axis tracking CdTe system located in Colorado, United States. """ -# sphinx_gallery_thumbnail_path = "../../_images/OEDI_9068_inverter1_comparison.png" # %% # This example model uses satellite-based solar resource data from the @@ -23,6 +22,8 @@ import pandas as pd import matplotlib.pyplot as plt +# sphinx_gallery_thumbnail_path = "../../_images/OEDI_9068_inverter1_comparison.png" + # %% # System parameters # ----------------- From 3283a89197ff877b5653c6037303fb6f8f00bef1 Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Tue, 2 Apr 2024 19:01:16 +0200 Subject: [PATCH 06/14] Trim extra spaces --- docs/examples/system-models/plot_oedi_9068.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index 09f51f4b9e..b3fa187890 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -48,7 +48,7 @@ # "unofficial" information -# We know the system uses 117.5 W CdTe modules. Based on the system vintage +# We know the system uses 117.5 W CdTe modules. Based on the system vintage # (data begins in 2017), it seems likely that the array uses First Solar # Series 4 modules (FS-4117). cec_module_db = pvlib.pvsystem.retrieve_sam('cecmod') @@ -68,7 +68,7 @@ cec_inverter_db = pvlib.pvsystem.retrieve_sam('cecinverter') inverter_parameters = cec_inverter_db['TMEIC__PVL_L1833GRM'] -# We'll use the PVWatts v5 losses model. Set shading to zero as it is +# We'll use the PVWatts v5 losses model. Set shading to zero as it is # accounted for elsewhere in the model, and disable availability loss since # we want a "clean" simulation. # Leaving the other pvwatts loss types (mismatch, wiring, etc) unspecified @@ -76,7 +76,7 @@ losses_parameters = dict(shading=0, availability=0) # Google Street View images show that each row is four modules high, in -# landscape orientation. Assuming the modules are First Solar Series 4, +# landscape orientation. Assuming the modules are First Solar Series 4, # each of them is 600 mm wide. # Assume ~1 centimeter gap between modules (three gaps total). # And from Google Earth, the array's pitch is estimated to be about 7.0 meters. From 8d891434d014980a9c214fcfc2aa0eac80b4f8d8 Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Tue, 2 Apr 2024 19:07:18 +0200 Subject: [PATCH 07/14] another try --- docs/examples/system-models/plot_oedi_9068.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index b3fa187890..eea80e6d12 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -6,6 +6,8 @@ Colorado, United States. """ +# sphinx_gallery_thumbnail_path = "_images/OEDI_9068_inverter1_comparison.png" + # %% # This example model uses satellite-based solar resource data from the # NSRDB PSM3. This approach is useful for pre-construction energy modeling @@ -22,8 +24,6 @@ import pandas as pd import matplotlib.pyplot as plt -# sphinx_gallery_thumbnail_path = "../../_images/OEDI_9068_inverter1_comparison.png" - # %% # System parameters # ----------------- From 33a4d261ca18551750f4e79062bfdcf7308918e0 Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Tue, 2 Apr 2024 21:09:53 +0200 Subject: [PATCH 08/14] Another try, remove config from output --- docs/examples/system-models/plot_oedi_9068.py | 2 +- docs/sphinx/source/conf.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index eea80e6d12..cbc2372704 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -6,7 +6,7 @@ Colorado, United States. """ -# sphinx_gallery_thumbnail_path = "_images/OEDI_9068_inverter1_comparison.png" +# sphinx_gallery_thumbnail_path = '_images/pvlib_logo_vert.png' # noqa: E501 # %% # This example model uses satellite-based solar resource data from the diff --git a/docs/sphinx/source/conf.py b/docs/sphinx/source/conf.py index b868a8a8c7..4083dec1a5 100644 --- a/docs/sphinx/source/conf.py +++ b/docs/sphinx/source/conf.py @@ -366,6 +366,9 @@ def setup(app): # Modules for which function/class level galleries are created. In # this case only pvlib, could include others though. must be tuple of str 'doc_module': ('pvlib',), + + # https://sphinx-gallery.github.io/dev/configuration.html#removing-config-comments # noqa: E501 + 'remove_config_comments': True, } # supress warnings in gallery output # https://sphinx-gallery.github.io/stable/configuration.html From e526c67cd414e36916be220872ef4b7758fe00d3 Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Tue, 2 Apr 2024 21:10:18 +0200 Subject: [PATCH 09/14] Update conf.py --- docs/sphinx/source/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/conf.py b/docs/sphinx/source/conf.py index 4083dec1a5..93c1e63527 100644 --- a/docs/sphinx/source/conf.py +++ b/docs/sphinx/source/conf.py @@ -364,7 +364,7 @@ def setup(app): 'backreferences_dir': 'reference/generated/gallery_backreferences', # Modules for which function/class level galleries are created. In - # this case only pvlib, could include others though. must be tuple of str + # this case only pvlib, could include others though. Must be tuple of str 'doc_module': ('pvlib',), # https://sphinx-gallery.github.io/dev/configuration.html#removing-config-comments # noqa: E501 From 7255cc77c9518a8878babaac594446244171d38d Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Tue, 2 Apr 2024 22:39:26 +0200 Subject: [PATCH 10/14] Bad news, RTD works incrementally - locally it works --- docs/examples/system-models/plot_oedi_9068.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index cbc2372704..9a0ea64704 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -6,7 +6,7 @@ Colorado, United States. """ -# sphinx_gallery_thumbnail_path = '_images/pvlib_logo_vert.png' # noqa: E501 +# sphinx_gallery_thumbnail_path = "_images/OEDI_9068_daily_timeseries.png" # %% # This example model uses satellite-based solar resource data from the From 99f807384af783dd2780e926e12a8ce37f946ac4 Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Wed, 3 Apr 2024 18:24:17 +0200 Subject: [PATCH 11/14] Try to remove config option code block --- docs/examples/system-models/plot_oedi_9068.py | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index 9a0ea64704..d93bcb9521 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -5,7 +5,6 @@ A basic model of a 4.7 MW single-axis tracking CdTe system located in Colorado, United States. """ - # sphinx_gallery_thumbnail_path = "_images/OEDI_9068_daily_timeseries.png" # %% From fc51b5b34ef32c75394c5677e7de868dc9253270 Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Wed, 3 Apr 2024 18:30:21 +0200 Subject: [PATCH 12/14] Update plot_oedi_9068.py --- docs/examples/system-models/plot_oedi_9068.py | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index d93bcb9521..49598bccf5 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -6,7 +6,6 @@ Colorado, United States. """ # sphinx_gallery_thumbnail_path = "_images/OEDI_9068_daily_timeseries.png" - # %% # This example model uses satellite-based solar resource data from the # NSRDB PSM3. This approach is useful for pre-construction energy modeling From f1cfaf8cf9d07d60b8c119b5884bf7f1c6a7f88d Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Wed, 3 Apr 2024 18:36:39 +0200 Subject: [PATCH 13/14] Update plot_oedi_9068.py --- docs/examples/system-models/plot_oedi_9068.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index 49598bccf5..ebfc512cda 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -5,8 +5,8 @@ A basic model of a 4.7 MW single-axis tracking CdTe system located in Colorado, United States. """ -# sphinx_gallery_thumbnail_path = "_images/OEDI_9068_daily_timeseries.png" # %% +# sphinx_gallery_thumbnail_path = "_images/OEDI_9068_daily_timeseries.png" # This example model uses satellite-based solar resource data from the # NSRDB PSM3. This approach is useful for pre-construction energy modeling # and in retrospective analyses where the system’s own irradiance From 291309d1dbcaafe4b461108f8243ccc04c496e4a Mon Sep 17 00:00:00 2001 From: echedey-ls <80125792+echedey-ls@users.noreply.github.com> Date: Wed, 3 Apr 2024 19:00:08 +0200 Subject: [PATCH 14/14] Update plot_oedi_9068.py --- docs/examples/system-models/plot_oedi_9068.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/system-models/plot_oedi_9068.py b/docs/examples/system-models/plot_oedi_9068.py index ebfc512cda..02487eff77 100644 --- a/docs/examples/system-models/plot_oedi_9068.py +++ b/docs/examples/system-models/plot_oedi_9068.py @@ -6,7 +6,6 @@ Colorado, United States. """ # %% -# sphinx_gallery_thumbnail_path = "_images/OEDI_9068_daily_timeseries.png" # This example model uses satellite-based solar resource data from the # NSRDB PSM3. This approach is useful for pre-construction energy modeling # and in retrospective analyses where the system’s own irradiance @@ -18,6 +17,7 @@ # For more information about the system, see its `OEDI # page `__. +# sphinx_gallery_thumbnail_path = "_images/OEDI_9068_daily_timeseries.png" import pvlib import pandas as pd import matplotlib.pyplot as plt