Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire argument deprecation warnings #456

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

dnerini
Copy link
Member

@dnerini dnerini commented Feb 3, 2025

This PR enforces the deprecation warnings that have been present in previous versions. The following arguments in the forecast functions across different modules have been officially deprecated and replaced:

pysteps.nowcasts.linda

  • precip_fields becomes precip
  • advection_field becomes velocity
  • num_ens_members becomes n_ens_members

pysteps.nowcasts.sprog

  • R becomes precip
  • V becomes velocity
  • R_thr becomes precip_thr

pysteps.nowcasts.sseps

  • R becomes precip
  • V becomes velocity

@dnerini dnerini merged commit 1cc4b26 into master Feb 3, 2025
8 checks passed
@dnerini dnerini deleted the expire-argument-deprecation-warnings branch February 3, 2025 21:46
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.24%. Comparing base (5ede008) to head (2c31ee7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   84.31%   84.24%   -0.08%     
==========================================
  Files         160      160              
  Lines       13249    13243       -6     
==========================================
- Hits        11171    11156      -15     
- Misses       2078     2087       +9     
Flag Coverage Δ
unit_tests 84.24% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant