-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub actions MacOS #1319
Fix GitHub actions MacOS #1319
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1319 +/- ##
========================================
Coverage 98.11% 98.11%
========================================
Files 272 272
Lines 15340 15340
========================================
Hits 15051 15051
Misses 289 289 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @brosaplanella
Thanks Ferran! Would it be possible to add one or two comments explaining why these lines where added? With a link with relevant references if this is inspired from something else. |
Two relevant issues are: |
I have now added the extra information. I only implemented the fix for gcc, which was basically what it was suggested by the error message. Let me know if I should add anything else. |
Description
Looks like our issue with the MacOs tests evolved and now it doesn't randomly fail anymore. I have found that adding solves it
brew unlink gcc@8 gcc@9
(I hope it doesn't break anything down the line...).