Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub actions MacOS #1319

Merged
merged 5 commits into from
Jan 6, 2021

Conversation

brosaplanella
Copy link
Member

Description

Looks like our issue with the MacOs tests evolved and now it doesn't randomly fail anymore. I have found that adding solves it
brew unlink gcc@8 gcc@9 (I hope it doesn't break anything down the line...).

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1319 (b2cd13a) into develop (cd833d0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1319   +/-   ##
========================================
  Coverage    98.11%   98.11%           
========================================
  Files          272      272           
  Lines        15340    15340           
========================================
  Hits         15051    15051           
  Misses         289      289           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd833d0...b2cd13a. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @brosaplanella

@tlestang
Copy link
Contributor

tlestang commented Jan 6, 2021

Thanks Ferran! Would it be possible to add one or two comments explaining why these lines where added? With a link with relevant references if this is inspired from something else.

@tlestang
Copy link
Contributor

tlestang commented Jan 6, 2021

@brosaplanella
Copy link
Member Author

Two relevant issues are:

I have now added the extra information. I only implemented the fix for gcc, which was basically what it was suggested by the error message. Let me know if I should add anything else.

@brosaplanella brosaplanella merged commit 562e14a into pybamm-team:develop Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants