diff --git a/include/pybind11/pytypes.h b/include/pybind11/pytypes.h index 3244ed8c525..d19763f6450 100644 --- a/include/pybind11/pytypes.h +++ b/include/pybind11/pytypes.h @@ -906,7 +906,7 @@ class str : public object { Return a string representation of the object. This is analogous to the ``str()`` function in Python. \endrst */ - explicit str(handle h) : object(raw_str(h.ptr()), stolen_t{}) { } + explicit str(handle h) : object(raw_str(h.ptr()), stolen_t{}) { if (!m_ptr) throw error_already_set(); } operator std::string() const { object temp = *this; @@ -931,8 +931,8 @@ class str : public object { /// Return string representation -- always returns a new reference, even if already a str static PyObject *raw_str(PyObject *op) { PyObject *str_value = PyObject_Str(op); - if (!str_value) throw error_already_set(); #if PY_MAJOR_VERSION < 3 + if (!str_value) throw error_already_set(); PyObject *unicode = PyUnicode_FromEncodedObject(str_value, "utf-8", nullptr); Py_XDECREF(str_value); str_value = unicode; #endif diff --git a/tests/test_pytypes.cpp b/tests/test_pytypes.cpp index 0f8d56410f0..e884f5af418 100644 --- a/tests/test_pytypes.cpp +++ b/tests/test_pytypes.cpp @@ -80,6 +80,7 @@ TEST_SUBMODULE(pytypes, m) { m.def("str_from_bytes", []() { return py::str(py::bytes("boo", 3)); }); m.def("str_from_object", [](const py::object& obj) { return py::str(obj); }); m.def("repr_from_object", [](const py::object& obj) { return py::repr(obj); }); + m.def("str_from_handle", [](py::handle h) { return py::str(h); }); m.def("str_format", []() { auto s1 = "{} + {} = {}"_s.format(1, 2, 3); diff --git a/tests/test_pytypes.py b/tests/test_pytypes.py index 0d1db1097c9..918e74a23db 100644 --- a/tests/test_pytypes.py +++ b/tests/test_pytypes.py @@ -102,11 +102,20 @@ def __repr__(self): assert m.str_from_object(A()) == "this is a str" assert m.repr_from_object(A()) == "this is a repr" + assert m.str_from_handle(A()) == "this is a str" s1, s2 = m.str_format() assert s1 == "1 + 2 = 3" assert s1 == s2 + malformed_utf8 = b"\x80" + with pytest.raises(UnicodeDecodeError) as excinfo: + assert m.str_from_object(malformed_utf8) + assert 'invalid start byte' in str(excinfo.value) + with pytest.raises(UnicodeDecodeError) as excinfo: + assert m.str_from_handle(malformed_utf8) + assert 'invalid start byte' in str(excinfo.value) + def test_bytes(doc): assert m.bytes_from_string().decode() == "foo"