Final manual curation in preparation for global clang-formating
#3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
reviewed
Feb 10, 2022
| @@ -44,10 +44,12 @@ struct buffer_info { | |||
| void *ptr = nullptr; // Pointer to the underlying storage | |||
| ssize_t itemsize = 0; // Size of individual items in bytes | |||
| ssize_t size = 0; // Total number of entries | |||
| std::string format; // For homogeneous buffers, this should be set to format_descriptor<T>::format() | |||
| std::string format; // For homogeneous buffers, this should be set to | |||
There was a problem hiding this comment.
FWIW, for these sorts of things, I'd do something like:
<empty line>
// Comment
std::string thing;
That will format much better, remain readable, and use less horizontal space for some extra vertical space.
No need to do that now. But that would be my general solution.
There was a problem hiding this comment.
I was going back and forth myself exactly here, then decided clang-format is actually doing a very nice job, preserving the original intent (no semi-pun intended). It's not obvious here, but if you look under #3713 it's great there. — But I'm happy to change it around. What do you prefer? Put only some comments on top, as needed? Or all, systematically?
There was a problem hiding this comment.
Let's go with that then. Merge at your discretion.
henryiii
reviewed
Feb 10, 2022
Comment on lines
+997
to
+1001
| // Placeholder type for the unneeded (and dead code) static variable in the | ||
| // PYBIND11_OVERRIDE_OVERRIDE macro | ||
| struct override_unused {}; |
henryiii
approved these changes
Feb 10, 2022
added 4 commits
February 10, 2022 09:47
Informed by work under pybind#3683: pybind@60b7eb4 pybind@59572e6
Very labor-intensive and dull.
rwgk
force-pushed
the
clang-format_T-1
branch
from
413a047 to
a1c898f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After this PR is merged we are ready for the last fully-automatic step: PR #3713.
Informed by experimental work under #3708, which is this PR + clang-format in pre-commit.
Suggested changelog entry: