-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Adjust default imu stationary thresholds #1105
Comments
It would certainly be good to adjust them. I was at a busy event recently and couldn't get the calibration to pass in some conditions. |
This makes sure that the defaults work better in noisier conditions. Fixes pybricks/support#1105
Done!
I have now set this to 2500 deg/s^2, which should make it less susceptible to vibrations. It will still register a knock on the table, which is more or less intended when it comes to stationary detection. What do you think? |
@scatwang and @DrTom: This is where we introduced the relaxed thresholds. I think you have found in #1840 and #1687 that the current defaults are not sensitive enough. So 1.5 deg/s was too strict and 5 deg/s was too lax. I suppose that means we could consider 3 deg/s. Maybe it was mainly the acceleration threshold that was too sensitive in noisy FLL/WRO environments, so maybe we should leave that at this high 2500 value. |
We'll also want to update both in the documentation. pybricks/pybricks-micropython@8809277 was also not documented. |
The fix is available for testing using these instructions to try the latest version Please re-open if you experience any further issues or inconsistencies. Thank you! |
This was closed by GitHub action but the documentation hasn't been updated yet, so re-opening. |
Now that it is a bit less sensitive to outliers, we can reduce this value. See pybricks/support#1105
Originally posted by @Kermit647 in #1080 (reply in thread)
The text was updated successfully, but these errors were encountered: