Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-system requirements #189

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Update build-system requirements #189

merged 1 commit into from
Nov 18, 2022

Conversation

dvzrv
Copy link
Contributor

@dvzrv dvzrv commented Nov 18, 2022

pyproject.toml:
Update build-system requirements for setuptools-scm to >= 7.0.0 which obsoletes setuptools-scm-git-archive.
Remove wheel, as it is not required for a PEP517 workflow with pypa/build and pypa/installer.

@dvzrv dvzrv requested a review from ssbarnea as a code owner November 18, 2022 12:04
@dvzrv
Copy link
Contributor Author

dvzrv commented Nov 18, 2022

argh, the project is still testing against 3.6.
Can that be dropped? Should that be done in a separate PR?

@ssbarnea
Copy link
Member

Yes, drop-it in separated PR as you know the drill. Ping me if green so I can help you merge them. I am looking to add more maintainers as I do have too many cats to herd.

@dvzrv
Copy link
Contributor Author

dvzrv commented Nov 18, 2022

Yes, drop-it in separated PR as you know the drill. Ping me if green so I can help you merge them.

#190

I am looking to add more maintainers as I do have too many cats to herd.

Welcome to my world... ;-)

@hartwork hartwork added the enhancement This issue/PR relates to a feature request. label Nov 18, 2022
pyproject.toml:
Update build-system requirements for setuptools-scm to >= 7.0.0 which
obsoletes setuptools-scm-git-archive.
Remove wheel, as it is not required for a PEP517 workflow with
pypa/build and pypa/installer.
@dvzrv
Copy link
Contributor Author

dvzrv commented Nov 18, 2022

Alright, it's rebased and should be good to go!

@ssbarnea ssbarnea added bug This issue/PR relates to a bug. and removed enhancement This issue/PR relates to a feature request. labels Nov 18, 2022
@ssbarnea ssbarnea merged commit be9c47d into pycontribs:main Nov 18, 2022
@@ -1,9 +1,7 @@
[build-system]
requires = [
"setuptools >= 41.0.0",
"setuptools_scm >= 6.0.1",
"setuptools_scm_git_archive >= 1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't even used — there's no .git_archival.txt present in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants