Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/test_ansi2html.py: use sys.executable instead of hardcoded python3 #214

Merged
merged 1 commit into from
May 9, 2023
Merged

tests/test_ansi2html.py: use sys.executable instead of hardcoded python3 #214

merged 1 commit into from
May 9, 2023

Conversation

johanneskastl
Copy link
Contributor

fixes #210

@hartwork hartwork added the enhancement This issue/PR relates to a feature request. label May 9, 2023
hartwork
hartwork approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@hartwork hartwork left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the change looks good in isolation, to get a green CI at https://github.com/pycontribs/ansi2html/actions/runs/4925721788/jobs/8800292224?pr=214#step:8:40 we probably need a dedicated pull request to appease flake8 first, and then rebase onto latest main after merge.

@hartwork
Copy link
Collaborator

hartwork commented May 9, 2023

@johanneskastl with pull request #207 merged just now, there is a good chance that flake8 and the CI will be happy after a rebase onto latest main. Could you do that?

@johanneskastl
Copy link
Contributor Author

@johanneskastl with pull request #207 merged just now, there is a good chance that flake8 and the CI will be happy after a rebase onto latest main. Could you do that?

Sure, stay tuned...

@johanneskastl johanneskastl force-pushed the 20230509_fix_hardcoded_python3_executable_name branch from 0f3962c to 51e758d Compare May 9, 2023 13:21
@johanneskastl
Copy link
Contributor Author

@hartwork CI looks green, hooray!

@hartwork hartwork merged commit 5ad94d1 into pycontribs:main May 9, 2023
@hartwork
Copy link
Collaborator

hartwork commented May 9, 2023

@johanneskastl thanks! 👍

@ssbarnea ssbarnea added bug This issue/PR relates to a bug. and removed enhancement This issue/PR relates to a feature request. labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartwork hartwork hartwork approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hardcoded "python3" in tests/test_ansi2html.py
3 participants
@johanneskastl @hartwork @ssbarnea