Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rye instead of Poetry #5

Merged
merged 11 commits into from
Apr 25, 2024
Merged

Use Rye instead of Poetry #5

merged 11 commits into from
Apr 25, 2024

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Apr 25, 2024

No description provided.

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looking good.

- uses: pre-commit/action@v3.0.1
with:
extra_args: --all-files --verbose
- uses: eifinger/setup-rye@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely simplest to just run pre-commit in CI like other projects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not simple, I'll add pre-commit here later.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@Kludex Kludex merged commit 8eab23c into main Apr 25, 2024
1 check passed
@Kludex Kludex deleted the use-rye-instead-of-poetry branch April 25, 2024 09:02
Kludex added a commit that referenced this pull request Apr 26, 2024
* Push

* use rye

* Sync instead

* Add pip

* Add pre-commit

* Use rye instead of standalone commands

* Lint without pre-commit

* Install rye via curl

* install properly

* Add mkdocs packages

* move up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants