Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cls reference to TypedDictSchema #1410

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

sydney-runkle
Copy link
Member

This follows the pattern we use for models and dataclasses, so we might as well be consistent here and remove the coupling from metadata.

Copy link

codspeed-hq bot commented Aug 19, 2024

CodSpeed Performance Report

Merging #1410 will not alter performance

Comparing typed-dict-to-schema (45aad17) with main (de04f03)

Summary

✅ 155 untouched benchmarks

Copy link
Member

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@sydney-runkle sydney-runkle merged commit b127652 into main Aug 19, 2024
29 checks passed
@sydney-runkle sydney-runkle deleted the typed-dict-to-schema branch August 19, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants