refactor out common str serialization logic #1867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Oct 29, 2025
| ObType::Generator => self.generator_object.as_ptr() as usize == ob_type, | ||
| ObType::Path => self.path_object.as_ptr() as usize == ob_type, | ||
| ObType::Pattern => self.path_object.as_ptr() as usize == ob_type, | ||
| ObType::Pattern => self.pattern_object.as_ptr() as usize == ob_type, |
Contributor
Author
There was a problem hiding this comment.
Clippy caught a legitimate typo here, I'm not sure if it's actually observable in practice though.
davidhewitt
commented
Oct 29, 2025
| let py_url: PyMultiHostUrl = value.extract()?; | ||
| py_url.__str__(py).into_py_any(py)? | ||
| } | ||
| ObType::Url | ObType::MultiHostUrl | ObType::Path => serialize_via_str(value, serialize_to_python())?, |
Contributor
Author
There was a problem hiding this comment.
e.g. IPAddress pathway will be added here
CodSpeed Performance ReportMerging #1867 will degrade performances by 11.62%Comparing Summary
Benchmarks breakdown
|
Viicos
approved these changes
Oct 29, 2025
davidhewitt
added a commit
to pydantic/pydantic
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
In advance of fixing #1856, I wanted to set up standard machinery for formatting Python objects to strings by calling
str(), this is all the IP address serialization will do.clippy::match_same_armslint which encourages us to deduplicate some code.Related issue number
N/A
Checklist
pydantic-core(except for expected changes)