Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence some warnings. #2328

Merged
merged 16 commits into from
Sep 4, 2018
Merged

Silence some warnings. #2328

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
482ecf6
Fix some warnings.
Jul 29, 2018
6b46b15
Make sure dask tests work with dask=0.16
Jul 29, 2018
75cce6c
Silence some pnetcdf warnings.
Jul 29, 2018
7518bd7
fix sel_points, isel_points fancy indexing tests
Jul 29, 2018
7186644
Revert to using xr.ufuncs
Jul 29, 2018
1f1ec52
Fix overflow/underflow warnings in interpolate_na
Jul 29, 2018
9ac15ef
Rescale datetime for interp() too.
Jul 29, 2018
76f988f
Better rescaling.
Jul 30, 2018
f605d6e
Revert "Better rescaling."
Aug 20, 2018
9729f29
Revert "Rescale datetime for interp() too."
Aug 20, 2018
cee7e2a
Revert "Fix overflow/underflow warnings in interpolate_na"
Aug 20, 2018
fbdb206
Silence overflow/underflow/invalid value warnings.
Aug 20, 2018
b985127
Silence a bottleneck warning.
Aug 20, 2018
d9e8024
Revert "Silence a bottleneck warning."
Sep 3, 2018
2c0ed18
Dask: change from attribute check to version check.
Sep 4, 2018
a74f4e0
Maybe this fixes python 2 failure?
Sep 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions xarray/tests/test_dataarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3532,6 +3532,8 @@ def test_rolling_reduce(da, center, min_periods, window, name):
@pytest.mark.parametrize('min_periods', (None, 1, 2, 3))
@pytest.mark.parametrize('window', (1, 2, 3, 4))
@pytest.mark.parametrize('name', ('sum', 'max'))
@pytest.mark.filterwarnings('ignore:Using a non-tuple sequence')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silences a warning that seems to be thrown by code in bottleneck

xarray/tests/test_dataarray.py::test_rolling_reduce_nonnumeric[sum-1-3-False]
  /home/travis/miniconda/envs/test_env/lib/python3.6/site-packages/bottleneck/slow/move.py:149: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
    nidx1 = n[idx1]
  /home/travis/miniconda/envs/test_env/lib/python3.6/site-packages/bottleneck/slow/move.py:150: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
    nidx1 = nidx1 - n[idx2]
  /home/travis/miniconda/envs/test_env/lib/python3.6/site-packages/bottleneck/slow/move.py:152: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
    idx[idx1] = nidx1 < min_count
  /home/travis/miniconda/envs/test_env/lib/python3.6/site-packages/bottleneck/slow/move.py:153: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
    idx[idx3] = n[idx3] < min_count

Copy link
Member

@shoyer shoyer Aug 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- can you file a report in bottleneck? I expect this would be easy to fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Filed a report upstream pydata/bottleneck#194 and reverted this commit.

# root cause of the warning is bottleneck
def test_rolling_reduce_nonnumeric(center, min_periods, window, name):
da = DataArray([0, np.nan, 1, 2, np.nan, 3, 4, 5, np.nan, 6, 7],
dims='time').isnull()
Expand Down