Replace the last of unittest with pytest #2467

max-sixty · 2018-10-06T01:15:45Z

This replaces (by-and-large) any remaining unittest implementations with pytest implementations. This allows us to use fixtures on any test; the existing implementation does not let us use them on TestCase instances. It also directs future contributors away from using the legacy methods.

Would be great to merge this fairly soon, as there's some chance of merge conflicts (which git may not catch - e.g. someone writing self.assertEqual). I'll try and chase down any test breaks as soon as possible.

pep8speaks · 2018-10-06T01:16:03Z

Hello @max-sixty! Thanks for updating the PR.

There are no PEP8 issues in the file xarray/tests/__init__.py !
There are no PEP8 issues in the file xarray/tests/test_accessors.py !
In the file xarray/tests/test_backends.py, following are the PEP8 issues :

Line 2436:38: E741 ambiguous variable name 'l'
Line 2436:58: E741 ambiguous variable name 'l'

There are no PEP8 issues in the file xarray/tests/test_combine.py !
There are no PEP8 issues in the file xarray/tests/test_conventions.py !
There are no PEP8 issues in the file xarray/tests/test_dask.py !
In the file xarray/tests/test_dataarray.py, following are the PEP8 issues :

Line 444:9: E741 ambiguous variable name 'I'

There are no PEP8 issues in the file xarray/tests/test_dataset.py !
There are no PEP8 issues in the file xarray/tests/test_duck_array_ops.py !
There are no PEP8 issues in the file xarray/tests/test_extensions.py !
There are no PEP8 issues in the file xarray/tests/test_formatting.py !
In the file xarray/tests/test_indexing.py, following are the PEP8 issues :

Line 27:9: E741 ambiguous variable name 'I'
Line 137:9: E741 ambiguous variable name 'I'
Line 157:9: E741 ambiguous variable name 'I'
Line 214:9: E741 ambiguous variable name 'I'
Line 526:5: E741 ambiguous variable name 'I'

There are no PEP8 issues in the file xarray/tests/test_merge.py !
There are no PEP8 issues in the file xarray/tests/test_plot.py !
There are no PEP8 issues in the file xarray/tests/test_tutorial.py !
There are no PEP8 issues in the file xarray/tests/test_utils.py !
There are no PEP8 issues in the file xarray/tests/test_variable.py !

Comment last updated on October 06, 2018 at 15:15 Hours UTC

max-sixty · 2018-10-06T01:25:22Z

Is @pep8speaks respecting # noqa directions? It's still complaining about ambiguous variable names here: https://github.com/max-sixty/xarray/blob/pytest/xarray/tests/test_indexing.py#L27

shoyer · 2018-10-06T07:37:33Z

xarray/tests/test_backends.py

@@ -1532,14 +1529,14 @@ def test_encoding_chunksizes(self):


 @requires_zarr
-class ZarrDictStoreTest(BaseZarrTest, TestCase):
+class ZarrDictStoreTest(BaseZarrTest, object):


There's no need to include object as a second base class for these classes :)

Some find/replaces going awry! Corrected

shoyer · 2018-10-06T07:40:47Z

xarray/tests/test_plot.py

@@ -65,7 +70,7 @@ def easy_array(shape, start=0, stop=1):


 @requires_matplotlib
-class PlotTestCase(TestCase):
+class PlotTestCase(unittest.TestCase):


I thought we were replacing the last of unittest here?

No worries on saving this for later, though :)

Yeah this one was tougher because of all the setup methods. But I found a reasonable way to do it systematically, so now that's done

shoyer · 2018-10-06T07:42:21Z

xarray/tests/test_backends.py

@@ -626,35 +626,35 @@ def test_unsigned_roundtrip_mask_and_scale(self):
        encoded = create_encoded_unsigned_masked_scaled_data()
        with self.roundtrip(decoded) as actual:
            for k in decoded.variables:
-                self.assertEqual(decoded.variables[k].dtype,
-                                 actual.variables[k].dtype)
+                assert decoded.variables[k].dtype == \


I prefer using parentheses to explicit line continuations (per PEP8), but I'm going to try to avoid being picky about it until we have automated tools that complain about it :)

Agree on the principle. I corrected a bunch of these where I could systematically, but still a few scattered around the repo.

shoyer · 2018-10-06T08:15:43Z

we can probably go ahead and safely merge this in its current state -- none of my comments are deal breakers

…ssible

max-sixty · 2018-10-06T15:24:45Z

I added a commit to clear up some of the issues that @shoyer found.

Assuming tests pass, I'll merge shortly given risk of conflicts - please lmk any final comments. I'm also happy to do any flups after merge this weekend.

shoyer · 2018-10-06T18:09:56Z

Thanks Maximilian!

…

On Sat, Oct 6, 2018 at 1:09 PM Maximilian Roos ***@***.***> wrote: Merged #2467 <#2467> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2467 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKS1ooi7R3npC2m27npvMxbEgYbLyXjks5uiOO7gaJpZM4XLHP3> .

* master: Replace the last of unittest with pytest (pydata#2467) Add python_requires to setup.py (pydata#2465) Clean up _parse_array_of_cftime_strings (pydata#2464) plot.contour: Don't make cmap if colors is a single color. (pydata#2453) np.AxisError was added in numpy 1.13 (pydata#2455) Add CFTimeIndex.shift (pydata#2431) Fix FutureWarning in CFTimeIndex.date_type (pydata#2448) fix:2445 (pydata#2446) Enable use of cftime.datetime coordinates with differentiate and interp (pydata#2434) restore ddof support in std (pydata#2447) Future warning for default reduction dimension of groupby (pydata#2366) Remove incorrect statement about "drop" in the text docs (pydata#2439) Use profile mechanism, not no-op mutation (pydata#2442) switch travis language to generic (pydata#2432)

* master: (51 commits) xarray.backends refactor (pydata#2261) Fix indexing error for data loaded with open_rasterio (pydata#2456) Properly support user-provided norm. (pydata#2443) pep8speaks (pydata#2462) isort (pydata#2469) tests shoudn't need to pass for a PR (pydata#2471) Replace the last of unittest with pytest (pydata#2467) Add python_requires to setup.py (pydata#2465) Update whats-new.rst (pydata#2466) Clean up _parse_array_of_cftime_strings (pydata#2464) plot.contour: Don't make cmap if colors is a single color. (pydata#2453) np.AxisError was added in numpy 1.13 (pydata#2455) Add CFTimeIndex.shift (pydata#2431) Fix FutureWarning in CFTimeIndex.date_type (pydata#2448) fix:2445 (pydata#2446) Enable use of cftime.datetime coordinates with differentiate and interp (pydata#2434) restore ddof support in std (pydata#2447) Future warning for default reduction dimension of groupby (pydata#2366) Remove incorrect statement about "drop" in the text docs (pydata#2439) Use profile mechanism, not no-op mutation (pydata#2442) ...

* master: (21 commits) xarray.backends refactor (pydata#2261) Fix indexing error for data loaded with open_rasterio (pydata#2456) Properly support user-provided norm. (pydata#2443) pep8speaks (pydata#2462) isort (pydata#2469) tests shoudn't need to pass for a PR (pydata#2471) Replace the last of unittest with pytest (pydata#2467) Add python_requires to setup.py (pydata#2465) Update whats-new.rst (pydata#2466) Clean up _parse_array_of_cftime_strings (pydata#2464) plot.contour: Don't make cmap if colors is a single color. (pydata#2453) np.AxisError was added in numpy 1.13 (pydata#2455) Add CFTimeIndex.shift (pydata#2431) Fix FutureWarning in CFTimeIndex.date_type (pydata#2448) fix:2445 (pydata#2446) Enable use of cftime.datetime coordinates with differentiate and interp (pydata#2434) restore ddof support in std (pydata#2447) Future warning for default reduction dimension of groupby (pydata#2366) Remove incorrect statement about "drop" in the text docs (pydata#2439) Use profile mechanism, not no-op mutation (pydata#2442) ...

max-sixty added 8 commits October 5, 2018 19:53

cleaning

5900c43

remove assertEqual

9e65036

Merge branch 'master' into shift

35dddf9

remove assertItems

c0532ae

more removing assertitems

a236743

remove assertequal

ca75df3

remove TestCase

f60adc6

straggler

f58c6ab

max-sixty added 2 commits October 5, 2018 21:19

pep8replies

0684ab3

pep8replies2

3dfd9ee

max-sixty added 5 commits October 5, 2018 21:43

small flups

583215f

pytest.warns requires Warning class

395f69d

tuple list comparisons

33d9391

disable test check

3a72b83

set / list

adc19b9

shoyer reviewed Oct 6, 2018

View reviewed changes

the last unittest survivor, and automated formatting changes where po…

391b1df

…ssible

max-sixty mentioned this pull request Oct 6, 2018

pep8speaks #2462

Merged

1 task

max-sixty merged commit bb87a94 into pydata:master Oct 6, 2018

max-sixty deleted the pytest branch October 6, 2018 17:09

fmaussion mentioned this pull request Oct 7, 2018

Does pep8speaks follow #noqa flags? pep8speaks-org/pep8speaks#96

Closed

shoyer mentioned this pull request Oct 11, 2018

Fix backend test classes so they actually run #2479

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace the last of unittest with pytest #2467

Replace the last of unittest with pytest #2467

max-sixty commented Oct 6, 2018 •

edited

Loading

pep8speaks commented Oct 6, 2018 •

edited

Loading

max-sixty commented Oct 6, 2018

shoyer Oct 6, 2018

max-sixty Oct 6, 2018

shoyer Oct 6, 2018

max-sixty Oct 6, 2018

shoyer Oct 6, 2018

max-sixty Oct 6, 2018

shoyer commented Oct 6, 2018

max-sixty commented Oct 6, 2018

shoyer commented Oct 6, 2018 via email

Replace the last of unittest with pytest #2467

Replace the last of unittest with pytest #2467

Conversation

max-sixty commented Oct 6, 2018 • edited Loading

pep8speaks commented Oct 6, 2018 • edited Loading

Comment last updated on October 06, 2018 at 15:15 Hours UTC

max-sixty commented Oct 6, 2018

shoyer Oct 6, 2018

Choose a reason for hiding this comment

max-sixty Oct 6, 2018

Choose a reason for hiding this comment

shoyer Oct 6, 2018

Choose a reason for hiding this comment

max-sixty Oct 6, 2018

Choose a reason for hiding this comment

shoyer Oct 6, 2018

Choose a reason for hiding this comment

max-sixty Oct 6, 2018

Choose a reason for hiding this comment

shoyer commented Oct 6, 2018

max-sixty commented Oct 6, 2018

shoyer commented Oct 6, 2018 via email

max-sixty commented Oct 6, 2018 •

edited

Loading

pep8speaks commented Oct 6, 2018 •

edited

Loading