From a9b631017a464f022f90bfdced22ec92d2388a13 Mon Sep 17 00:00:00 2001 From: Deepak Cherian Date: Thu, 14 Mar 2024 21:26:35 -0600 Subject: [PATCH 1/3] Add dask-expr for windows envs --- ci/requirements/environment-windows-3.12.yml | 1 + ci/requirements/environment-windows.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/ci/requirements/environment-windows-3.12.yml b/ci/requirements/environment-windows-3.12.yml index 5b3034b7a20..448e3f70c0c 100644 --- a/ci/requirements/environment-windows-3.12.yml +++ b/ci/requirements/environment-windows-3.12.yml @@ -8,6 +8,7 @@ dependencies: - cartopy - cftime - dask-core + - dask-expr - distributed - flox - fsspec diff --git a/ci/requirements/environment-windows.yml b/ci/requirements/environment-windows.yml index cc361bac5e9..c1027b525d0 100644 --- a/ci/requirements/environment-windows.yml +++ b/ci/requirements/environment-windows.yml @@ -8,6 +8,7 @@ dependencies: - cartopy - cftime - dask-core + - dask-expr - distributed - flox - fsspec From de5c3268e61bcb92b3a421acceee12caa88cf675 Mon Sep 17 00:00:00 2001 From: Deepak Cherian Date: Thu, 14 Mar 2024 21:40:48 -0600 Subject: [PATCH 2/3] Add xfail --- xarray/tests/test_dataarray.py | 1 + 1 file changed, 1 insertion(+) diff --git a/xarray/tests/test_dataarray.py b/xarray/tests/test_dataarray.py index 5ab20b2c29c..2e510549cb7 100644 --- a/xarray/tests/test_dataarray.py +++ b/xarray/tests/test_dataarray.py @@ -3420,6 +3420,7 @@ def test_to_dataframe_0length(self) -> None: @requires_dask_expr @requires_dask + @pytest.mark.xfail("dask-expr is broken") def test_to_dask_dataframe(self) -> None: arr_np = np.arange(3 * 4).reshape(3, 4) arr = DataArray(arr_np, [("B", [1, 2, 3]), ("A", list("cdef"))], name="foo") From 0083a583c19ddb96847728feabb8d3a71d0dc4af Mon Sep 17 00:00:00 2001 From: Deepak Cherian Date: Thu, 14 Mar 2024 21:41:25 -0600 Subject: [PATCH 3/3] xfail --- xarray/tests/test_dataarray.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xarray/tests/test_dataarray.py b/xarray/tests/test_dataarray.py index 2e510549cb7..04112a16ab3 100644 --- a/xarray/tests/test_dataarray.py +++ b/xarray/tests/test_dataarray.py @@ -3420,7 +3420,7 @@ def test_to_dataframe_0length(self) -> None: @requires_dask_expr @requires_dask - @pytest.mark.xfail("dask-expr is broken") + @pytest.mark.xfail(reason="dask-expr is broken") def test_to_dask_dataframe(self) -> None: arr_np = np.arange(3 * 4).reshape(3, 4) arr = DataArray(arr_np, [("B", [1, 2, 3]), ("A", list("cdef"))], name="foo")