Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty code cell in examples/multidimensional-coords.ipynb #9071

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer
Copy link
Contributor Author

@keewis Sorry to bother you, are the checks not running by design when changing only docs? Otherwise this little fix is good to go.

@keewis
Copy link
Collaborator

keewis commented Jun 7, 2024

I think so, yes. Look at the rules at the top of the workflow definition:

paths:
- "ci/**"
- ".github/**"
- "/*" # covers files such as `pyproject.toml`
- "/.*" # ...and dotfiles in the root such as `.pre-commit-config.yaml`
- "properties/**"
- "xarray/**"
This excludes anything in /doc.

In any case, since this simply removes an empty cell I'll go ahead and merge.

@keewis keewis merged commit 75a3e47 into pydata:main Jun 7, 2024
8 checks passed
@kmuehlbauer
Copy link
Contributor Author

@keewis Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in examples/multidimensional-coords.html
2 participants