Fix seed for random test data. #9844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also switch to using default_rng instead of RandomState.
dcherian
commented
Dec 2, 2024
| @@ -298,12 +298,12 @@ def assert_allclose(a, b, check_default_indexes=True, **kwargs): | |||
|
|
|||
|
|
|||
| def create_test_data( | |||
| seed: int | None = None, | |||
| seed: int = 12345, | |||
There was a problem hiding this comment.
this is the real change, the rest is just find+replace
max-sixty
approved these changes
Dec 2, 2024
headtr1ck
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also switch to using the recommended
default_rnginstead ofRandomState.