typing: Gio: Make ListModel and ListStore generic #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
force-pushed
the
gio-generic-list
branch
from
b96cc91
to
c111163
Compare
|
Hmm, my app crashes when I try to use it so probably requires changes to pygobject itself: Traceback (most recent call last):
File "/nix/store/m8l8vlxnp3a5wbvrx162qzjfakbayds8-nonemast-0.1.0/bin/..nonemast-wrapped-wrapped", line 30, in <module>
from nonemast import main
File "/nix/store/m8l8vlxnp3a5wbvrx162qzjfakbayds8-nonemast-0.1.0/share/nonemast/nonemast/main.py", line 11, in <module>
from .window import NonemastWindow
File "/nix/store/m8l8vlxnp3a5wbvrx162qzjfakbayds8-nonemast-0.1.0/share/nonemast/nonemast/window.py", line 19, in <module>
from .operations import ensure_coauthors
File "/nix/store/m8l8vlxnp3a5wbvrx162qzjfakbayds8-nonemast-0.1.0/share/nonemast/nonemast/operations/ensure_coauthors.py", line 17, in <module>
def ensure_coauthors(updates: Gio.ListStore[PackageUpdate]) -> None:
TypeError: 'GObjectMeta' object is not subscriptableEdit: Opened https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/237 |
jtojnar
force-pushed
the
gio-generic-list
branch
from
c111163
to
55f34ca
Compare
lovetox
reviewed
Feb 10, 2024
| def __getitem__(self, position: int) -> GObject.Object: ... | ||
| def __iter__(self) -> Iterator[GObject.Object]: ... | ||
| class ListModel(GObject.GInterface, Generic[ItemType]): | ||
| # override |
There was a problem hiding this comment.
i dont think thats necessary, if the class itself has a "override" annotation, then it will be completely ignored by the generator. So no need to add override to each method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.