Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch expected lengths #62

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Patch expected lengths #62

merged 1 commit into from
Nov 23, 2023

Conversation

liamhuber
Copy link
Member

I think we just had an off-by-one error when touching up the script.

Closes #61

I think we just had an off-by-one error when touching up the script.
Copy link
Member

@niklassiemer niklassiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry for the hiccup! Of course if len != n: False should translate to if len < n : False if we want to allow for larger n, I probably misjudged thinking about len == n: vs. len >= n+1.

@niklassiemer niklassiemer merged commit bf1f8ff into main Nov 23, 2023
@niklassiemer niklassiemer deleted the hotfix_env_updater branch November 23, 2023 07:42
@liamhuber
Copy link
Member Author

Yes, sorry for the hiccup! Of course if len != n: False should translate to if len < n : False if we want to allow for larger n, I probably misjudged thinking about len == n: vs. len >= n+1.

I don't know how much culpability you intend to assume with the word "sorry", but I reviewed it so I refuse to let you take more than half 😂 It was a dumb mistake, but the fact is those are going to happen and they're why we have tests, so what I'm really learning from this is we need a better testing routine for this repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Dependabot PR titles are not parsing
2 participants