Change field order to drop Environment last #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the order of the field to drop Environment after everything else.
The current code gets stuck, randomly but steadily, during the drop. What happened is that
SessionPointerHolder
held by the session is dropped after theEnvironment
, and this seems to cause it to be blocked indefinitely.This is an example code that shows that the program gets stuck. This happens with both ort 1.15 and 1.16. It happens with different models.
With the proposed fix, it doesn't get stuck anymore. This could also be achieved by adding an env field after
session
inModel
, but sinceSession
already holds anEnvironment
, it shouldn't be needed.