Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let TypeAlias be a statement #2250

Merged

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
🐛 Bug fix

Description

Follow-up to fbcff3a (so no changelog).

Fixes issue found in pylint primer.

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #2250 (bcb2091) into main (4d77ff6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2250      +/-   ##
==========================================
+ Coverage   92.77%   92.80%   +0.02%     
==========================================
  Files          94       94              
  Lines       10941    10941              
==========================================
+ Hits        10151    10154       +3     
+ Misses        790      787       -3     
Flag Coverage Δ
linux 92.61% <100.00%> (+0.02%) ⬆️
pypy 90.89% <100.00%> (ø)
windows 92.37% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/nodes/node_classes.py 94.82% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on making python 3.12 works @jacobtylerwalls !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 908c384 into pylint-dev:main Jul 15, 2023
@jacobtylerwalls jacobtylerwalls deleted the type-alias-statement branch July 15, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants