Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated node_classes, scoped_nodes, and mixins modules #2300

Merged
merged 4 commits into from
Sep 24, 2023

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Sep 23, 2023

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Closes #1072
Refs #1633

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #2300 (4b197af) into main (ea78827) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
- Coverage   92.85%   92.85%   -0.01%     
==========================================
  Files          94       94              
  Lines       11058    11053       -5     
==========================================
- Hits        10268    10263       -5     
  Misses        790      790              
Flag Coverage Ξ”
linux 92.66% <ΓΈ> (-0.01%) ⬇️
pypy 90.99% <ΓΈ> (-0.02%) ⬇️
windows 92.44% <ΓΈ> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Ξ”
astroid/__init__.py 100.00% <ΓΈ> (ΓΈ)

... and 1 file with indirect coverage changes

@jacobtylerwalls jacobtylerwalls changed the title Remove deprecated node_classes and scoped_nodes modules Remove deprecated node_classes, scoped_nodes, and mixins modules Sep 23, 2023
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won a battle against circular imports today ❀️ (and apparently in the past without realizing because ruff did not need the exclude autoflake required)

Comment on lines -92 to -93
# Please remove astroid/scoped_nodes.py|astroid/node_classes.py in autoflake
# exclude when removing this file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like autoflake is not relevant anymore as we did move to ruff already.

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining astroid or the dev workflow breaking-change labels Sep 24, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.0 milestone Sep 24, 2023
@Pierre-Sassoulas
Copy link
Member

Wanted to rebase and squash the reword comment but I can't push to this branch, I'm going to just squash it's not that important.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 1a12842 into main Sep 24, 2023
20 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the remove-modules branch September 24, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated astroid.node_classes and astroid.scoped_nodes
2 participants