-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated node_classes
, scoped_nodes
, and mixins
modules
#2300
Conversation
5e62ab3
to
4fe8b85
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2300 +/- ##
==========================================
- Coverage 92.85% 92.85% -0.01%
==========================================
Files 94 94
Lines 11058 11053 -5
==========================================
- Hits 10268 10263 -5
Misses 790 790
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Unused since f96e18b.
c03a18a
to
bf7a47e
Compare
node_classes
and scoped_nodes
modulesnode_classes
, scoped_nodes
, and mixins
modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won a battle against circular imports today β€οΈ (and apparently in the past without realizing because ruff did not need the exclude autoflake required)
# Please remove astroid/scoped_nodes.py|astroid/node_classes.py in autoflake | ||
# exclude when removing this file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like autoflake is not relevant anymore as we did move to ruff already.
Wanted to rebase and squash the reword comment but I can't push to this branch, I'm going to just squash it's not that important. |
Type of Changes
Description
Closes #1072
Refs #1633