Add python 3.13 to the continuous integration #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
Pierre-Sassoulas
force-pushed
the
try-out-python-3.13
branch
from
d45d880 to
8743572
Compare
jacobtylerwalls
force-pushed
the
try-out-python-3.13
branch
2 times, most recently
from
5a2fffb to
4a4f9cf
Compare
Pierre-Sassoulas
commented
Jul 6, 2024
| @@ -8,6 +8,7 @@ numpy>=1.17.0; python_version<"3.12" | |||
| python-dateutil | |||
| PyQt6 | |||
| regex | |||
| setuptools | |||
There was a problem hiding this comment.
Oof, is that avoidable ? I don't see what changed in this MR to warrant that, si it means we already were depending on setuptools ?
There was a problem hiding this comment.
Exactly. Uninstall setuptools, run pytest -k namespace, see:
tests/test_manager.py:124:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
import warnings
with warnings.catch_warnings():
warnings.simplefilter("ignore", DeprecationWarning)
> __import__("pkg_resources").declare_namespace(__name__)
E AttributeError: module 'pkg_resources' has no attribute 'declare_namespace'
tests/testdata/python3/data/path_pkg_resources_1/package/__init__.py:5: AttributeError
===================================== short test summary info ======================================
FAILED tests/test_manager.py::AstroidManagerTest::test_identify_old_namespace_package_protocol - AttributeError: module 'pkg_resources' has no attribute 'declare_namespace'
========================== 1 failed, 10 passed, 1675 deselected in 1.18s ===========================We could do this in a separate MR if you like, but I figured a separate commit was enough.
There was a problem hiding this comment.
Isn't this a test dependencie and not a runtime dependencie ?
There was a problem hiding this comment.
I think that's what this file is. (My commit message is slightly wrong, should say test dependency)
jacobtylerwalls
force-pushed
the
try-out-python-3.13
branch
from
fc0e9b6 to
25a0b35
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2424 +/- ##
=======================================
Coverage 92.74% 92.75%
=======================================
Files 94 94
Lines 10993 11007 +14
=======================================
+ Hits 10195 10209 +14
Misses 798 798
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jacobtylerwalls
force-pushed
the
try-out-python-3.13
branch
from
517eb3f to
bdb7568
Compare
DanielNoord
reviewed
Jul 8, 2024
DanielNoord
approved these changes
Jul 8, 2024
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Add compatibility with Python 3.13.