[compare to zero] Fix false positive with 'x is False'

Author: Pierre-Sassoulas

pylint/extensions/comparetozero.py

@@ -21,7 +21,11 @@
 
 
 def _is_constant_zero(node: str | nodes.NodeNG) -> bool:
-    return isinstance(node, astroid.Const) and node.value == 0
+    # We have to check that node.value is not False because node.value == 0 is True
+    # when node.value is False
+    return (
+        isinstance(node, astroid.Const) and node.value == 0 and node.value is not False
+    )
 
 
 class CompareToZeroChecker(checkers.BaseChecker):

tests/functional/ext/comparetozero/compare_to_zero.py

@@ -6,9 +6,15 @@
 if X is 0:  # [compare-to-zero]
     pass
 
+if X is False:
+    pass
+
 if Y is not 0:  # [compare-to-zero]
     pass
 
+if Y is not False:
+    pass
+
 if X == 0:  # [compare-to-zero]
     pass
 

tests/functional/ext/comparetozero/compare_to_zero.txt

@@ -1,6 +1,6 @@
 compare-to-zero:6:3:6:9::"""X is 0"" can be simplified to ""not X"" as 0 is falsey":HIGH
-compare-to-zero:9:3:9:13::"""Y is not 0"" can be simplified to ""Y"" as 0 is falsey":HIGH
-compare-to-zero:12:3:12:9::"""X == 0"" can be simplified to ""not X"" as 0 is falsey":HIGH
-compare-to-zero:15:3:15:9::"""0 == Y"" can be simplified to ""not Y"" as 0 is falsey":HIGH
-compare-to-zero:18:3:18:9::"""Y != 0"" can be simplified to ""Y"" as 0 is falsey":HIGH
-compare-to-zero:21:3:21:9::"""0 != X"" can be simplified to ""X"" as 0 is falsey":HIGH
+compare-to-zero:12:3:12:13::"""Y is not 0"" can be simplified to ""Y"" as 0 is falsey":HIGH
+compare-to-zero:18:3:18:9::"""X == 0"" can be simplified to ""not X"" as 0 is falsey":HIGH
+compare-to-zero:21:3:21:9::"""0 == Y"" can be simplified to ""not Y"" as 0 is falsey":HIGH
+compare-to-zero:24:3:24:9::"""Y != 0"" can be simplified to ""Y"" as 0 is falsey":HIGH
+compare-to-zero:27:3:27:9::"""0 != X"" can be simplified to ""X"" as 0 is falsey":HIGH