Disable design by default

[danrneal]

Description

This PR disables the design checker by default. The only time I have seen these messages be used effectively, has been when the arbitrary default parameters are configured to a team/individual's liking. It follows that if a user is savvy enough to configure the design parameters, they are savvy enough to enable the checker. However, for someone who is looking for a pip-and-play option, these messages can be a nuisance.

The design checker in my opinion should not be removed from pylint because they can be powerful when configured, but without proper configuration (which is highly individualistic), they should be disabled.

Type of Changes

	Type
✓	🔨 Refactoring
✓	📜 Docs

Related Issue

Starts to address #3512

[Pierre-Sassoulas]

Thanks for the merge request. I'm going to wait for another reviewer opinion before merging.

[coveralls]

Coverage increased (+0.002%) to 90.688% when pulling bc9e78e on danrneal:disable-design-by-default into 1ad2f25 on PyCQA:master.

[coveralls]

Coverage increased (+0.002%) to 90.688% when pulling bc9e78e on danrneal:disable-design-by-default into 1ad2f25 on PyCQA:master.

[coveralls]

Coverage increased (+0.001%) to 90.724% when pulling e1deda5 on danrneal:disable-design-by-default into e602fda on PyCQA:master.

[hippo91]

Thanks for this PR @danrneal !
Honestly i'm a bit ill at ease with it because there is a discussion about how to improve pylint (#746) and one of the item concerns the default message system.
I definitely think that deactivating some default messages is what we need but maybe deactivating a whole module is a bit too strong. @AWhetter , @PCManticore, @Pierre-Sassoulas what do you think about it?

[danrneal]

I know not everyone agrees with me but my point of view has always been that there are no 'sane' defaults for design parameters as those are very org/project dependent and need to be tuned to be of any use. Those who are savvy enough to tune them are savvy enough to turn them on as well. However, those looking for a plug-and-play works-out-of-the-box linter, will get only frustration from this module.

I do think it is a good addition to add documentation as to how to turn it on and will add that! Thanks!

[hippo91]

@danrneal thanks for this. I'm ok with it, and find it's a good idea. I would like to have opinions of @AWhetter @PCManticore and @Pierre-Sassoulas about it before merging.

[Pierre-Sassoulas]

I think @PCManticore gave his opinion here, this is probably best discussed in the #3512 directly.

[AWhetter]

I feel like we're jumping the gun a bit. We haven't really reached a consensuses on #3512 yet. We're not sure exactly which messages we want disabled by default, how we want to disable them and allow re-enabling, and whether we need to consider doing a major version bump for this change.
I would prefer for us to finish these design discussions first (although I'm aware of the lack of activity on #3512). I think it's less important to know exactly which messages we want enabled or disabled by default because I think it's likely to change over time.

[Pierre-Sassoulas]

Removing approval as consensus is not reached.

[hippo91]

@Pierre-Sassoulas @AWhetter thanks for your answer. Let's wait for a consensus on #3512 so.

[Pierre-Sassoulas]

Closing because of inactivity.