Skip to content

Conversation

@timmartin
Copy link
Contributor

Refactoring to prevent warnings being issued on these lines from a new
checker.

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

The new unnecessary-list-lookup checker being added in PR #5834 will cause regressions, refactoring to avoid this.

…4525)

Refactoring to prevent warnings being issued on these lines from a new
checker.
@DanielNoord DanielNoord changed the title Fix regressions from new unnecessary-list-lookup checker (#4525) Use value directly instead of index in enumerate contexts Mar 2, 2022
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timmartin πŸ‘

@DanielNoord DanielNoord added this to the 2.13.0 milestone Mar 2, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1924736598

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.997%

Totals Coverage Status
Change from base Build 1916776999: 0.0%
Covered Lines: 14937
Relevant Lines: 15891

πŸ’› - Coveralls

@DanielNoord DanielNoord merged commit 182cc53 into pylint-dev:main Mar 2, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Mar 2, 2022
@timmartin timmartin deleted the issue-4525-regression-fixes branch April 27, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Discussion or action around maintaining pylint or the dev workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants