-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FP used-before-assignment
for statements guarded under same test
#8581
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Fix false positive for ``used-before-assignment`` when usage and assignment | ||
are guarded by the same test in different statements. | ||
|
||
Closes #8167 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
"""Miscellaneous used-before-assignment cases""" | ||
# pylint: disable=consider-using-f-string, missing-function-docstring | ||
|
||
import datetime | ||
|
||
MSG = "hello %s" % MSG # [used-before-assignment] | ||
|
||
|
@@ -116,3 +116,50 @@ def turn_on2(**kwargs): | |
var, *args = (1, "restore_dimmer_state") | ||
|
||
print(var, *args) | ||
|
||
|
||
# Variables guarded by the same test when used. | ||
|
||
# Always false | ||
if __name__ == "__main__": | ||
PERCENT = 20 | ||
SALE = True | ||
|
||
if __name__ == "__main__": | ||
print(PERCENT) | ||
|
||
# Different test | ||
if __name__ is None: | ||
print(SALE) # [used-before-assignment] | ||
|
||
|
||
# Ambiguous, but same test | ||
if not datetime.date.today(): | ||
WAS_TODAY = True | ||
|
||
if not datetime.date.today(): | ||
print(WAS_TODAY) | ||
|
||
|
||
# Different tests but same inferred values | ||
# Need falsy values here | ||
def give_me_zero(): | ||
return 0 | ||
|
||
def give_me_nothing(): | ||
return 0 | ||
|
||
if give_me_zero(): | ||
WE_HAVE_ZERO = True | ||
ALL_DONE = True | ||
|
||
if give_me_nothing(): | ||
print(WE_HAVE_ZERO) | ||
|
||
|
||
# Different tests, different values | ||
def give_me_none(): | ||
return None | ||
|
||
if give_me_none(): | ||
print(ALL_DONE) # [used-before-assignment] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like those tests π |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of inference here, but the primer time vary in the same range than it usually does, so the performance impact is probably acceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm assuming that all of these nodes are inferred anyway elsewhere in the variables checker, so we're hitting the cache.