Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error where we can't get the imdb details request. #9797

Merged
merged 7 commits into from
Aug 14, 2021
Merged

Handle error where we can't get the imdb details request. #9797

merged 7 commits into from
Aug 14, 2021

Commits on Aug 14, 2021

  1. Handle error where we can't get the imdb details request.

    @p0psicles
    p0psicles committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    778b6ce View commit details
    Browse the repository at this point in the history

  2. Split up the imdb get_details and get_genres functions.

    @p0psicles
    p0psicles committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    bacfcdb View commit details
    Browse the repository at this point in the history

  3. clean up

    @p0psicles
    p0psicles committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    fe19775 View commit details
    Browse the repository at this point in the history

  4. Raise exception when it doesn't get back a result. Prevents it from c… 

    …aching empty response / connection errors.
    @p0psicles
    p0psicles committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    8efc321 View commit details
    Browse the repository at this point in the history

  5. Catch the exception.

    @p0psicles
    p0psicles committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    bb5bed2 View commit details
    Browse the repository at this point in the history

  6. unused import

    @p0psicles
    p0psicles committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    5b0e4f6 View commit details
    Browse the repository at this point in the history

  7. update changelog

    @p0psicles
    p0psicles committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    99e9ff8 View commit details
    Browse the repository at this point in the history