Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fixed caused by passing wrong arg #1336

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Conversation

AKJ7
Copy link
Contributor

@AKJ7 AKJ7 commented Feb 9, 2023

  • Fixed a bug: got multiple values for keyword argument 'slave'

* Fixed a bug: `got multiple values for keyword argument 'slave'`
@AKJ7
Copy link
Contributor Author

AKJ7 commented Feb 9, 2023

Reproduce error:

  • Run REPL interface
  • use readwrite_register command

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@janiversen
Copy link
Collaborator

Ups, I did not check the repl client, good catch. Lets see what CI says.

@janiversen janiversen merged commit 12859d0 into pymodbus-dev:dev Feb 9, 2023
@janiversen
Copy link
Collaborator

Thanks, it will be part of the upcoming 3.2 (due in 1-2 weeks).

sthelen-enqs pushed a commit to sthelen-enqs/pymodbus that referenced this pull request Feb 15, 2023
* Bug: Fixed caused by passing wrong arg
alexrudd2 pushed a commit to alexrudd2/pymodbus that referenced this pull request Feb 21, 2023
* Bug: Fixed caused by passing wrong arg
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants