Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for writing multiple writes with a single value #1402

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Add tests for writing multiple writes with a single value #1402

merged 4 commits into from
Mar 3, 2023

Conversation

alexrudd2
Copy link
Collaborator

Closes #1363

Currently there are only tests for e.g. write_coils([list]). This adds them for write_coils(bool).

See also #1377

@alexrudd2 alexrudd2 marked this pull request as ready for review March 3, 2023 05:35
janiversen
janiversen approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit e19b103 into dev Mar 3, 2023
@janiversen janiversen deleted the issue-1363 branch March 3, 2023 07:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should non-list values be allowed for multiple writes?
2 participants
@alexrudd2 @janiversen