Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make baud rate configurable for examples #1410

Merged

Conversation

jakeru
Copy link
Contributor

@jakeru jakeru commented Mar 7, 2023

This makes it possible for users to specify the baud rate when running an example application which is communicating over a serial device.

The default baud rate is 9600 bps as before.

This change only applies to the example applications.

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen
Copy link
Collaborator

Seems you broke our tests:

FAILED test/test_examples.py::test_exp_async_server_client[serial-ModbusRtuFramer-5020-10] - AttributeError: 'Commandline' object has no attribute 'baudrate'

@janiversen
Copy link
Collaborator

I will merge once it is solved and CI gives the green light.

This makes it possible for users to specify the baud rate when running
an example application which is communicating over a serial device.

The default baud rate is 9600 bps as before.

This change only applies to the example applications.
@jakeru jakeru force-pushed the configure-baudrate-for-examples branch from 959a5e5 to d4754db Compare March 7, 2023 15:13
@jakeru
Copy link
Contributor Author

jakeru commented Mar 7, 2023

Seems you broke our tests:

FAILED test/test_examples.py::test_exp_async_server_client[serial-ModbusRtuFramer-5020-10] - AttributeError: 'Commandline' object has no attribute 'baudrate'

Oops. Fixed. And this time I actually ran the unit tests. 😊

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@janiversen janiversen merged commit e73493a into pymodbus-dev:dev Mar 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants