Correct pylint configuration.

[janiversen]

Allow pylint to work with broad exceptions again.

[janiversen]

@jamesbraza seems your latest commit broke pylint, I have no idea why our CI did not catch it

[alexrudd2]

I also don't understand, but found this:

pylint: Command line or configuration file:1: UserWarning: Specifying exception names in the overgeneral-exceptions option without module name is deprecated and support for it will be removed in pylint 3.0. Use fully qualified name (maybe 'builtins.Exception' ?) instead.

[janiversen]

That was exactly what caused the problem.

[jamesbraza]

Oh actually that change from Exception to builtins.Exception was intentional: https://stackoverflow.com/questions/75370815/pylint-specifying-exception-names-in-the-overgeneral-exceptions-option-without

This message comes with newer pylint, which #1519 moved to.
overgeneral-exceptions=builtins.Exception is the correct configuration option.

Now after this PR, on my machine, I see all over the place:

pylint: Command line or configuration file:1: UserWarning: Specifying exception names in the overgeneral-exceptions option without module name is deprecated and support for it will be removed in pylint 3.0. Use fully qualified name (maybe 'builtins.Exception' ?) instead.
pylint: Command line or configuration file:1: UserWarning: Specifying exception names in the overgeneral-exceptions option without module name is deprecated and support for it will be removed in pylint 3.0. Use fully qualified name (maybe 'builtins.Exception' ?) instead.
pylint: Command line or configuration file:1: UserWarning: Specifying exception names in the overgeneral-exceptions option without module name is deprecated and support for it will be removed in pylint 3.0. Use fully qualified name (maybe 'builtins.Exception' ?) instead.

Note the warning is actually asking for builtins.Exception.

[jamesbraza]

While using pylint<3 (what we're using), this will be fine, but when we go to pylint>=3 this will ultimately break.

I would advocate for this PR to be reverted, so that we can roll smoothly into the future 👌

[janiversen]

sounds like a good idea, unless pylint continue telling me to remove the disable for a lot of lines (which for some reason seems solved with this PR).