Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-shared block doc in config.rst. #1573

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix non-shared block doc in config.rst. #1573

merged 1 commit into from
Jun 2, 2023

Conversation

haydenroche5
Copy link
Contributor

The doc says holding registers come before input registers, but that's not what the code does. handle_setup_section puts the input registers first.

@haydenroche5
Fix non-shared block doc in config.rst.
4a4ce64 
The doc says holding registers come before input registers, but that's not what
the code does. handle_setup_section puts the input registers first.
janiversen
janiversen approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@janiversen janiversen merged commit a685821 into pymodbus-dev:dev Jun 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haydenroche5 @janiversen