Remove dead code from framer #2094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please stop changing in framers and message (in message type changes etc are ok). At least these big changes that ruins my ongoing work. You are changing work in progress, without really changing it...e.g. the to_do files are to remember test cases. |
janiversen
requested changes
Mar 7, 2024
| IndexError # response length indeterminate with available bytes | ||
| ): | ||
| expected_response_length = ( | ||
| self.client.framer.get_expected_response_length( |
There was a problem hiding this comment.
Actually I think this needs to be changed to calling these 2 methods:
pdu_class = self.decoder.lookupPduClass(func_code)
return pdu_class.calculateRtuFrameSize(data)
I am quite sure I should not have removed it totally.
|
See #2096. We are very close to "throwing the switch" for more |
|
Done (sadly enough without a PR, due to a lapse in mind). |
|
Superseded by 504af27 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_expected_response_lengthwas totally removed in 9cf0724#diff-126482fdc00ef924006c76c322c03c809c8b598b66f0af83ab9f5aade84a6a11L314-L323 and therefore this entire branch is useless.