Restrict write_registers etc to list[int]. #2469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing in python is really BAD !!
every developer would read this:
as values can be either list[int] OR list[bytes], but mypy is stupid and requires values to be "list[int] | list[bytes]"
Using:
solves this problem, but do NOT allow the array to be changed.
As a consequence of this, the API from now on only accept list[int], which are NOT modified !!
If an app wants to use bytes, it must be converted to int before calling. The API contains different from/to register conversions that can help if needed.