Add possible abi version to lock info #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
abi-version
branch
5 times, most recently
from
dc45123
to
9536662
Compare
ryanking13
reviewed
May 22, 2024
|
|
||
| ### Added | ||
|
|
||
| - The `info` field now contains an optional `abi_version`. |
| @@ -103,7 +103,7 @@ def _generate_package_hash(full_path: Path) -> str: | |||
|
|
|||
|
|
|||
| def _get_marker_environment( | |||
| platform: str, version: str, arch: str, python: str | |||
| platform: str, version: str, arch: str, python: str, abi_version: str | None = None | |||
There was a problem hiding this comment.
The parameter doesn't seem to be used anywhere?
There was a problem hiding this comment.
But it gets passed and will crash if we don't accept it.
There was a problem hiding this comment.
I see... we should probably update the contest.py file then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.