Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running 'pip install --upgrade setuptools' with 'sudo' on macOS, fixing #122 #123

Merged
merged 1 commit into from
Feb 3, 2019

Conversation

YannickJadoul
Copy link
Member

Seems the fix to pip to #122 might still take some time to get released, and is not guaranteed to completely fix our problem. Adding --user to all pip install commands on macOS should be a harmless (?) fix to get cibuildwheel working again, though.

The other option would be to add sudo to the pip install --upgrade setuptools call. If you prefer that, I can change this PR.

@YannickJadoul YannickJadoul force-pushed the fix-issue-122 branch 2 times, most recently from 619f73b to c42dc23 Compare January 30, 2019 16:28
@YannickJadoul
Copy link
Member Author

OK, pip install --user does not work, because the --user directory is not on the macOS PATH.
Switching to sudo pip install --upgrade setuptools instead.

@YannickJadoul YannickJadoul changed the title Installing Python packages to user directory on macOS, fixing #122 Running 'pip install --upgrade setuptools' with 'sudo' on macOS, fixing #122 Jan 30, 2019
@joerick
Copy link
Contributor

joerick commented Jan 30, 2019

Great! This ready to go @YannickJadoul ?

@YannickJadoul
Copy link
Member Author

@joerick If you're happy with it, yes, go ahead. I'm not completely satisfied having a single 'sudo' in that whole list of install commands, but I think it's the best smallest change to make.

it also seems the fix to pip might actually be ready sooner than I thought a few hours ago, if I look at the progress, but ... yeah, I suppose we can release a fix, and if pip does allow to remove the sudo, potentially undo this change in the next non-urgent release? #121 is having us reconsider whether global installs are the way to go, anyway, right? So virtual environments would also cleanly solve this whole business.

@joerick joerick merged commit 56218d8 into pypa:master Feb 3, 2019
@YannickJadoul YannickJadoul deleted the fix-issue-122 branch February 4, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants