Revert temporary fix of #122 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one. No need to rebase, I'll squash and merge, once the tests are green. 👍 |
|
Oh, yeah, for the record, and future debugging and decisions: i realized that if Homebrew is correctly installed (and it seems it is, on Travis CI), permissions allow to install write to the Homebrew prefix without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was looking at #127, I realized the temporary fix to #122 (which turned out to be a similar but unrelated issue) is not necessary anymore now that
piphas been patched, fixing the issue.If @joerick would decide to release a new version soon to include #128, then this might as well be part of it, too?
This PR would (finally!) close #122.
And, oh, yes: I've based it on #128, to get the tests green, so I'd suggest to first merge #128, and then I could rebase this PR?