Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove setup.py and setup.cfg in packaging tutorial in favor of pyproject.toml #1085

Closed
wants to merge 4 commits into from

Conversation

venthur
Copy link
Contributor

@venthur venthur commented May 31, 2022

This PR, removes setup.py and setup.cfg and uses pyproject.toml for storing the meta data in the packaging tutorial.

closes: #1084

@bhrutledge bhrutledge self-requested a review May 31, 2022 09:43
@bhrutledge
Copy link
Contributor

Thanks, @venthur! This looks like a good start. However, it conflicts with #1031, which goes further to demonstrate how folks can use different build backends. There's a lively unresolved discussion about that approach, and which backend should be listed first. I think that PR is waiting on input/edits from myself and the author; I haven't been able to prioritize that recently.

FYI @abravalheri @henryiii @ofek. I'd like to avoid philosophical discussions on this PR, and focus on its technical accuracy, if we decide to just use setuptools. That's a big "if"; I'm tempted to resolve it via the packaging discussion forum.

@bhrutledge
Copy link
Contributor

In an attempt to get more feedback, I've started a discussion on the packaging forum.

@CAM-Gerlach
Copy link
Contributor

Just to note, while I personally prefer the #1031 approach for the reasons others have articulated on the thread and it seems that's the way things are going, if this does get accepted, you'll need to require at least setuptools>=61.0 in the build-system.requires section above, if not higher (possibly not yet released) to ensure full stability.

@venthur
Copy link
Contributor Author

venthur commented Jun 12, 2022

@CAM-Gerlach thanks for the heads-up. I updated the requirements to setuptools>=61.

@bhrutledge
Copy link
Contributor

Closing this in favor of #1031.

@bhrutledge bhrutledge closed this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it time to update the packaging tutorial to remove setup.py and setup.cfg
3 participants