Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Python 2 support #305

Closed
pradyunsg opened this issue May 15, 2020 · 9 comments · Fixed by #376
Closed

Dropping Python 2 support #305

pradyunsg opened this issue May 15, 2020 · 9 comments · Fixed by #376

Comments

@pradyunsg
Copy link
Member

pradyunsg commented May 15, 2020

My proposal: Drop it in 21.0. :)

Holler if you're not on board.

@ShadowJonathan
Copy link

Py2 is EOL, it would only make sense.

What minimal py3 version will be supported from now on then? I saw this being referenced from a PR in the context of typing, with typing annotations being added only in 3.5 (iirc)

@brettcannon
Copy link
Member

@ShadowJonathan it will depend on what pip chooses to support at the time we drop this.

@pradyunsg
Copy link
Member Author

pradyunsg commented May 23, 2020

I'd imagine we'll drop Python 3.5 as well (since it'll be EoL by Jan 2021), or at least, we'll drop it immediately after pip drops it.

@pradyunsg
Copy link
Member Author

Since no one is opposed to this, I say it's decided that we'll drop support for Python 2 from packaging in early 2021.

@pradyunsg
Copy link
Member Author

I'd say we should also deprecate 3.4 and 3.5 at the same time, since they're also EOL.

@brettcannon
Copy link
Member

So when are we going to do this? It's 2021 and @jdufresne was nice enough to beat all of us to a PR. Any reason to wait? Is one last Python 2 release necessary for Apple Silicon support?

@brettcannon
Copy link
Member

Release 20.9 is out. Any reason to put this off any longer?

@pradyunsg
Copy link
Member Author

Nope.

@brettcannon
Copy link
Member

Done! 🥳🎉🎊🍾 (there aren't enough emojis for this 😁).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants