From 0575cd766141c1f8441389ee5873ea8d6383d52c Mon Sep 17 00:00:00 2001 From: Hugo Date: Sun, 8 Sep 2019 15:10:43 +0300 Subject: [PATCH] Remove noqa workaround --- tests/functional/test_install.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/functional/test_install.py b/tests/functional/test_install.py index a8d3cf9628e..d3eb5c6e6cf 100644 --- a/tests/functional/test_install.py +++ b/tests/functional/test_install.py @@ -5,8 +5,7 @@ import textwrap from os.path import curdir, join, pardir -# Ignore because flake8 can't detect the use inside skipif(). -import pip._vendor.six # noqa: F401 +import pip._vendor.six import pytest from pip._internal import pep425tags @@ -21,6 +20,9 @@ from tests.lib.local_repos import local_checkout from tests.lib.path import Path +python3_only = pytest.mark.skipif(not pip._vendor.six.PY2, + reason="Python 3 only") + @pytest.mark.parametrize('command', ('install', 'wheel')) @pytest.mark.parametrize('variant', ('missing_setuptools', 'bad_setuptools')) @@ -530,7 +532,7 @@ def test_editable_install__local_dir_no_setup_py_with_pyproject( assert 'A "pyproject.toml" file was found' in msg -@pytest.mark.skipif("pip._vendor.six.PY3") +@python3_only @pytest.mark.xfail def test_install_argparse_shadowed(script): # When argparse is in the stdlib, we support installing it