Merge pull request #13523 from mtsokol/fix-rstrip

notatallshaw · web-flow · commit 1e3c66ec7c04 · 2025-09-11T00:04:55.000-04:00
Add `rstrip` in `def _strip_extras`
diff --git a/news/13523.bugfix.rst b/news/13523.bugfix.rst
@@ -0,0 +1 @@
+Permit spaces between a filepath and extras in an install requirement.
diff --git a/src/pip/_internal/req/constructors.py b/src/pip/_internal/req/constructors.py
@@ -47,7 +47,7 @@ def _strip_extras(path: str) -> tuple[str, str | None]:
     m = re.match(r"^(.+)(\[[^\]]+\])$", path)
     extras = None
     if m:
-        path_no_extras = m.group(1)
+        path_no_extras = m.group(1).rstrip()
         extras = m.group(2)
     else:
         path_no_extras = path
diff --git a/tests/unit/test_req.py b/tests/unit/test_req.py
@@ -768,6 +768,7 @@ def test_requirement_file(self) -> None:
             ("pkg [ext] == 1.0; python_version<='3.6'", "pkg==1.0"),
             ("pkg-all.allowed_chars0 ~= 2.0", "pkg-all.allowed_chars0~=2.0"),
             ("pkg-all.allowed_chars0 [ext] ~= 2.0", "pkg-all.allowed_chars0~=2.0"),
+            ("simple-0.1-py2.py3-none-any.whl [ext]", "simple==0.1"),
         ],
     )
     def test_install_req_drop_extras(self, inp: str, out: str) -> None:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Permit spaces between a filepath and extras in an install requirement.`
Original file line number	Diff line number	Diff line change
`@@ -768,6 +768,7 @@ def test_requirement_file(self) -> None:`
`768`	`768`	`("pkg [ext] == 1.0; python_version<='3.6'", "pkg==1.0"),`
`769`	`769`	`("pkg-all.allowed_chars0 ~= 2.0", "pkg-all.allowed_chars0~=2.0"),`
`770`	`770`	`("pkg-all.allowed_chars0 [ext] ~= 2.0", "pkg-all.allowed_chars0~=2.0"),`
	`771`	`+ ("simple-0.1-py2.py3-none-any.whl [ext]", "simple==0.1"),`
`771`	`772`	`],`
`772`	`773`	`)`
`773`	`774`	`def test_install_req_drop_extras(self, inp: str, out: str) -> None:`